New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change bool flags to str option. #170

Open

nstarman opened this issue Aug 30, 2023 · 0 comments

Contributor

nstarman commented Aug 30, 2023

daft/src/daft/_core.py

Lines 570 to 572 in 7e859f2

    
           observed=False, 
        
           fixed=False, 
        
           alternate=False,

can be more succinctly represented as

kind: Literal["observed", "fixed", "alternate"] | None = None

This makes it impossible to pass more than one option and still easy to check that the option is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment