Skip to content

Commit 867bceb

Browse files
[dagster-tableau] Update Tableau docs to use translator instance and TableauTranslatorData (#26741)
## Summary & Motivation As title. ## How I Tested These Changes BK and docs preview
1 parent 33a89bf commit 867bceb

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

docs/content/api/modules.json.gz

0 Bytes
Binary file not shown.

docs/content/api/searchindex.json.gz

0 Bytes
Binary file not shown.

docs/content/api/sections.json.gz

0 Bytes
Binary file not shown.

docs/content/integrations/tableau.mdx

+3-3
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ from dagster_tableau import (
109109
TableauCloudWorkspace,
110110
load_tableau_asset_specs,
111111
)
112-
from dagster_tableau.translator import TableauContentData, TableauContentType
112+
from dagster_tableau.translator import TableauContentType, TableauTranslatorData
113113

114114
import dagster as dg
115115

@@ -126,7 +126,7 @@ tableau_workspace = TableauCloudWorkspace(
126126
# A translator class lets us customize properties of the built
127127
# Tableau assets, such as the owners or asset key
128128
class MyCustomTableauTranslator(DagsterTableauTranslator):
129-
def get_asset_spec(self, data: TableauContentData) -> dg.AssetSpec:
129+
def get_asset_spec(self, data: TableauTranslatorData) -> dg.AssetSpec:
130130
# We create the default asset spec using super()
131131
default_spec = super().get_asset_spec(data)
132132
# We customize the metadata and asset key prefix for all assets, including sheets,
@@ -144,7 +144,7 @@ class MyCustomTableauTranslator(DagsterTableauTranslator):
144144

145145
tableau_specs = load_tableau_asset_specs(
146146
tableau_workspace,
147-
dagster_tableau_translator=MyCustomTableauTranslator,
147+
dagster_tableau_translator=MyCustomTableauTranslator(),
148148
)
149149
defs = dg.Definitions(assets=[*tableau_specs], resources={"tableau": tableau_workspace})
150150
```

examples/docs_snippets/docs_snippets/integrations/tableau/customize-tableau-asset-defs.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
TableauCloudWorkspace,
44
load_tableau_asset_specs,
55
)
6-
from dagster_tableau.translator import TableauContentData, TableauContentType
6+
from dagster_tableau.translator import TableauContentType, TableauTranslatorData
77

88
import dagster as dg
99

@@ -20,9 +20,9 @@
2020
# A translator class lets us customize properties of the built
2121
# Tableau assets, such as the owners or asset key
2222
class MyCustomTableauTranslator(DagsterTableauTranslator):
23-
def get_asset_spec(self, data: TableauContentData) -> dg.AssetSpec:
23+
def get_asset_spec(self, data: TableauTranslatorData) -> dg.AssetSpec:
2424
# We create the default asset spec using super()
25-
default_spec = super().get_asset_spec(data) # type: ignore
25+
default_spec = super().get_asset_spec(data)
2626
# We customize the metadata and asset key prefix for all assets, including sheets,
2727
# and we customize the team owner tag only for sheets.
2828
return default_spec.replace_attributes(
@@ -38,6 +38,6 @@ def get_asset_spec(self, data: TableauContentData) -> dg.AssetSpec:
3838

3939
tableau_specs = load_tableau_asset_specs(
4040
tableau_workspace,
41-
dagster_tableau_translator=MyCustomTableauTranslator,
41+
dagster_tableau_translator=MyCustomTableauTranslator(),
4242
)
4343
defs = dg.Definitions(assets=[*tableau_specs], resources={"tableau": tableau_workspace})

0 commit comments

Comments
 (0)