Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Improve parameter handling #737

Open
yohamta opened this issue Dec 10, 2024 · 4 comments
Open

cmd: Improve parameter handling #737

yohamta opened this issue Dec 10, 2024 · 4 comments
Assignees
Labels
enhancement New feature to be implemented

Comments

@yohamta
Copy link
Collaborator

yohamta commented Dec 10, 2024

Overview
I'd like to propose improving the command-line parameter passing syntax for Dagu. The current approach using --params can be unintuitive and less user-friendly compared to common CLI patterns.

Current Syntax

dagu start --params="a b c" xxx.yaml

Proposed Syntax

dagu start xxx.yaml -- a b c

Benefits

  1. Follows the widely-used command-line convention where -- separates options from positional arguments
  2. More intuitive for users familiar with other CLI tools (e.g., docker, kubectl)
  3. Makes it clearer where the parameters begin and end
  4. Easier to work with parameters containing spaces or special characters
  5. Better shell completion support

This change would make Dagu's CLI more consistent with standard Unix/Linux command-line practices while maintaining backwards compatibility with the existing --params flag.

@yohamta yohamta added the enhancement New feature to be implemented label Dec 10, 2024
@kriyanshii
Copy link
Contributor

hey, would love to work on this, will submit pr on this soon.

@yohamta
Copy link
Collaborator Author

yohamta commented Dec 21, 2024

Hey @kriyanshii, that would be great thanks! Please make sure that you have synced the fork with the latest main branch before working on it, as I've made substantial refactoring in cmd/ package today. Thanks!

@yohamta
Copy link
Collaborator Author

yohamta commented Dec 27, 2024

Hey @kriyanshii, just checking if you're still planning to work on this issue? If not, I'd be happy to take it up :)

@kriyanshii
Copy link
Contributor

kriyanshii commented Dec 27, 2024 via email

kriyanshii added a commit to kriyanshii/dagu that referenced this issue Dec 29, 2024
@yohamta yohamta changed the title Improve parameter handling cmd: Improve parameter handling Dec 29, 2024
kriyanshii added a commit to kriyanshii/dagu that referenced this issue Dec 29, 2024
kriyanshii added a commit to kriyanshii/dagu that referenced this issue Jan 1, 2025
kriyanshii added a commit to kriyanshii/dagu that referenced this issue Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature to be implemented
Projects
None yet
Development

No branches or pull requests

2 participants