Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Links with SVG icons only need to have accessable text #114

Open
dan-mba opened this issue Sep 17, 2024 · 1 comment
Open

chore: Links with SVG icons only need to have accessable text #114

dan-mba opened this issue Sep 17, 2024 · 1 comment

Comments

@dan-mba
Copy link

dan-mba commented Sep 17, 2024

Describe the bug
Any link needs text that can be accessed by a screen reader.
Most of the links on the site that use an SVG icon (socials, etc) do not.
SocialLinks.tsx

Options to fix this:
Add aria-label to the link
Add sr-only span within the link (link to tailwind implementation of sr-only)

@GetBlackBoxSolutions GetBlackBoxSolutions changed the title Links with SVG icons only need to have accessable text chore: Links with SVG icons only need to have accessable text Nov 3, 2024
@PratikThoratNortheastern
Copy link

PratikThoratNortheastern commented Nov 4, 2024

Hey, Can I work on this? I created a fork and I am in the process of understanding the code base, May be this issue can help me do so and contribute to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants