Pull-requests support or issues-only?

[kdeldycke]

Required Information

Entering this information will route you directly to the right team and expedite traction.

Question, Bug, or Feature?
Type: Question

Should this get assigned to @damccorm?
Assign to damccorm: yes

Issue Description

Does that plugin work for PRs too or is tag-ur-it only designed for issues only?

[damccorm]

As of now its for issues only. In theory I don't think it would be that hard to extend for PRs, I think it would probably be changes here:

tag-ur-it/src/index.ts

Line 13 in 4cf02d3

if (github.context.payload.action !== 'opened') {

, and here:

tag-ur-it/src/index.ts

Line 18 in 4cf02d3

if (!github.context.payload.issue) {

along with some changes to the inputs to make sure we can maintain back compat (ideally the default behavior would be to enable it only on issues, with the option to enable it on PRs or both).

I don't have the bandwidth to take this on right now, but would be happy to review a pr :)

[kdeldycke]

Thanks @damccorm for the quick feedback! Supporting PRs is indeed doable. If I find the bandwidth too I'll be happy to contribute! :)

[damccorm]

Lets leave this one open to track this as an enhancement!

[kdeldycke]

OK no worries. I was just trying to not pollute your backlog! :)

[jenlampton]

I'm confused as to where the labels get assigned. I'm looking for a solution to add the label of "has pull request" to an issue that, obviously, has a pull request.

Is this enhancement asking to add labels onto PRs, or to add lables onto issues when PRs are filed?

[kdeldycke]

@jenlampton The former. So this feature request is about "teaching" tag-ur-it to add labels to PRs, the same way it currently does with issues.