Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded style overrides height/width props #11

Open
siegerts opened this issue Jan 28, 2021 · 0 comments
Open

Hardcoded style overrides height/width props #11

siegerts opened this issue Jan 28, 2021 · 0 comments

Comments

@siegerts
Copy link

Hi @damienroche,

Thanks for the lib!

In trying to adjust the height/width of the BlurHashImage, I noticed that the hardcode 100% values in the subcomponents are not respecting the height/width props.

Wondering what your thoughts are on passing those provided props into the style definitions?

Something like -

:style="`height: ${height}px; width: ${width}px; position: absolute; top: 0; left: 0; right: 0; bottom: 0;`"

instead of

style="height: 100%; width: 100%; position: absolute; top: 0; left: 0; right: 0; bottom: 0;"

I'm happy to submit a PR if it works for you.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant