Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security concern #1341

Open
psmoros opened this issue Jul 1, 2023 · 12 comments · May be fixed by #2121
Open

Security concern #1341

psmoros opened this issue Jul 1, 2023 · 12 comments · May be fixed by #2121
Assignees
Labels
Milestone

Comments

@psmoros
Copy link

psmoros commented Jul 1, 2023

Hello 👋

I run a security community that finds and fixes vulnerabilities in OSS. A researcher (@prprhyt) has found a potential issue, which I would be eager to share with you.

Could you add a SECURITY.md file with an e-mail address for me to send further details to? GitHub recommends a security policy to ensure issues are responsibly disclosed, and it would help direct researchers in the future.

Looking forward to hearing from you 👍

(cc @huntr-helper)

@alltheseas
Copy link
Collaborator

Hello 👋

I run a security community that finds and fixes vulnerabilities in OSS. A researcher (@prprhyt) has found a potential issue, which I would be eager to share with you.

Could you add a SECURITY.md file with an e-mail address for me to send further details to? GitHub recommends a security policy to ensure issues are responsibly disclosed, and it would help direct researchers in the future.

Looking forward to hearing from you 👍

(cc @huntr-helper)

Thank you: can you kindly send to [email protected]

@prprhyt
Copy link
Contributor

prprhyt commented Jul 1, 2023

[email protected] is an open mailing list. So I think given the confidential thing of the information, a more private contact would be preferable.

By the way, I have been chatting with @jb55 a bit in advance at [email protected].

@jb55
Could you please check this?
What do you think?
I respect your decision.

@alltheseas
Copy link
Collaborator

Email Will directly at the email you mentioned in that case

@alltheseas alltheseas added this to the 1.6 Profile Zaps milestone Jul 1, 2023
@alltheseas alltheseas moved this to Unvalidated Request 🪨⛏️ in Damus Roadmap 🛣️ Jul 1, 2023
@jb55 jb55 moved this from Unvalidated Request 🪨⛏️ to Published to Testflight ✅ in Damus Roadmap 🛣️ Jul 4, 2023
@prprhyt
Copy link
Contributor

prprhyt commented Jul 5, 2023

@psmoros

Could you check the new SECURITY.md and contact @jb55 using his email address, if you have never contacted him yet?

@jb55
Copy link
Collaborator

jb55 commented Jul 29, 2023

The upcoming nostrdb changes fixes all this because the ingress thread will handle verification on all events before insertion into the database, similar to how strfry does it.

@alltheseas
Copy link
Collaborator

Does this mean with db update all incoming events are automagically validated?

@jb55
Copy link
Collaborator

jb55 commented Jul 29, 2023

Thats the plan

@alltheseas
Copy link
Collaborator

@jb55 is this resolved?

@jb55
Copy link
Collaborator

jb55 commented Sep 26, 2023 via email

@alltheseas
Copy link
Collaborator

On Mon, Sep 25, 2023 at 12:50:59PM -0700, alltheseas wrote: @jb55 is this resolved?
it will be when we switch to nostrdb for our note cache (soon), but not yet.

Do you want to commit to this for the sprint first half of October?

@jb55
Copy link
Collaborator

jb55 commented Oct 11, 2023 via email

@jb55 jb55 linked a pull request May 6, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Live
Development

Successfully merging a pull request may close this issue.

4 participants