Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: After changing LN address in my profile, I can't see any previous zaps sent to prior addresses. #2432

Open
Tracked by #2433
dmnyc opened this issue Sep 6, 2024 · 3 comments
Labels
Needs recreation Issues requires concrete steps for recreation unexpected zaps

Comments

@dmnyc
Copy link

dmnyc commented Sep 6, 2024

I switched my wallet address from [email protected] to [email protected].

Afterward, my Zap tab displayed no zaps sent to my previous address and only started recording zaps sent to my current one.

In addition, notes where I have received zaps do not show anything prior to the address change.

See the comparison of this note ID shown in Nostur, displaying 7 zaps for a total of over 2000 sats vs. Damus which only displays 1 zap of 3 sats.

note18a0y77xhk7lw0cge0qlyjcyg59n0gjmvhxt3az8w97uhwztgh9fsyqsru9

image
image

@dmnyc dmnyc added bug Something is not working, or not working as intended Needs recreation Issues requires concrete steps for recreation labels Sep 6, 2024
@alltheseas alltheseas added unexpected zaps and removed bug Something is not working, or not working as intended labels Sep 6, 2024
@jb55
Copy link
Collaborator

jb55 commented Sep 7, 2024

yes changing lnurl will invalidate older zaps, it's by design

@dmnyc
Copy link
Author

dmnyc commented Sep 7, 2024

I don't understand why Damus wouldn't display the total zap count on a note. If a note previously received zaps but someone changed their address at a later time wouldn't it still make sense to show the full amount that is visible on other clients?

https://nostr.band/note18a0y77xhk7lw0cge0qlyjcyg59n0gjmvhxt3az8w97uhwztgh9fsyqsru9

@jb55
Copy link
Collaborator

jb55 commented Sep 7, 2024

What we can do is mark a zap as valid, at the time of validation, and always maintain that state into the future. We just need to add this note metadata to nostrdb. This is most likey what all these other apps are doing. Damus has a DB but we don't fully integrate into it yet:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs recreation Issues requires concrete steps for recreation unexpected zaps
Projects
None yet
Development

No branches or pull requests

3 participants