From 7ef211a542528502734b39e28268b9638011a52b Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Sat, 3 Aug 2024 06:59:11 +0200 Subject: [PATCH] ggml: update freq_factors comment in rope.c Signed-off-by: Daniel Bevenius --- fundamentals/ggml/src/rope.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fundamentals/ggml/src/rope.c b/fundamentals/ggml/src/rope.c index 448d3d2c..07c5b435 100644 --- a/fundamentals/ggml/src/rope.c +++ b/fundamentals/ggml/src/rope.c @@ -79,8 +79,9 @@ int main(int argc, char **argv) { float beta_fast = 32.0f; // This is a YaRN parameter which I think is named β in the YaRN paper. float beta_slow = 1.0f; - // RoPE Frequency factors are used with certan models like - // Phi-3-mini-128k-instruct (https://huggingface.co/microsoft/Phi-3-mini-128k-instruct/blob/main/config.json#L27) + // LongRope Frequency factors (freq_factors/rope_scaling) are used with + // certain models like Phi-3-mini-128k-instruct + // (https://huggingface.co/microsoft/Phi-3-mini-128k-instruct/blob/main/config.json#L27). struct ggml_tensor* freq_factors = NULL; struct ggml_tensor* s = ggml_rope_ext(ctx,