Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do update dandisets' "modified" timestamp whenever assets metadata "gets fixed" #2050

Open
yarikoptic opened this issue Oct 17, 2024 · 1 comment

Comments

@yarikoptic
Copy link
Member

A number of dandisets got their assets metadata updated but dandiset time stamp was not modified.

I believe due to

    | --- old-metadata
    | +++ new-metadata
    | @@ -5,7 +5,7 @@
    |    '@context': https://raw.githubusercontent.com/dandi/schema/master/releases/0.6.6/context.json
    |    access:
    |    - schemaKey: AccessRequirements
    | -    status: dandi:OpenAccess
    | +    status: dandi:EmbargoedAccess
    |    approach:
    |    - name: electrophysiological approach
    |      schemaKey: ApproachType

Some might argue that metadata "fixes" should not result in dandiset "modified" time but in the current model IMHO they should. Without that API would not provide reliable means for efficient monitoring/mirroring of the archive (as we e.g. need for backups2datalad) since it would be impossible to rely on "modified" timestamp as indicator of having or not changes in the dandiset. Could

@yarikoptic
Copy link
Member Author

Similarly now happened due to a fix for .json files not having correct encodingtype.

IMHO there should be a generic interface which would ensure that mtime is adjusted if there are such mutations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant