Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require license selection at dandiset creation time #778

Closed
satra opened this issue Mar 29, 2021 · 7 comments
Closed

Require license selection at dandiset creation time #778

satra opened this issue Mar 29, 2021 · 7 comments
Labels
enhancement New feature or request UX Affects usability of the system

Comments

@satra
Copy link
Member

satra commented Mar 29, 2021

a license is a required element of every dandiset. can we add license selection when someone creates a dandiset (at present we are only allowing cc0 and ccby. the license types should be pulled in from dandi schema.

@waxlamp
Copy link
Member

waxlamp commented Jun 18, 2021

This seems to be done already.

@waxlamp waxlamp closed this as completed Jun 18, 2021
@satra
Copy link
Member Author

satra commented Jun 18, 2021

i'm not sure this is done already. clicking on new dandiset does not ask for a license. perhaps one thing that could be done is the new dandiset uses a version of the meditor but has a description saying what is required.

the minimum validation requirements for a dandiset are quite limited and perhaps that's a way to also reduce spam.

@satra satra reopened this Jun 18, 2021
@waxlamp
Copy link
Member

waxlamp commented Jun 21, 2021

Ah, you want the license selection to be required at the time of creation of the dandiset.

Is it not sufficient to make the license field required? Then the creator can defer the selection to later. What's the reason for forcing the selection at creation time?

(Perhaps a separate topic but--for that matter, what's the value in forcing a description at that time as well?)

@satra
Copy link
Member Author

satra commented Jun 21, 2021

i think just enough of a hill to climb to make people think about things.

@yarikoptic
Copy link
Member

What's the reason for forcing the selection at creation time?

One of the reasons could be: we are distributing draft versions of datasets. Before publish we otherwise wouldn't have a chance to enforce having a license for distributed draft version of the dandiset. Mandating having license specified at creation time resolves that.

@waxlamp waxlamp changed the title Dec 28, 2021
@ghost ghost assigned mvandenburgh Dec 28, 2021
@waxlamp waxlamp transferred this issue from dandi/dandiarchive-legacy Jan 13, 2022
@waxlamp waxlamp added enhancement New feature or request UX Affects usability of the system labels Jan 13, 2022
dchiquito pushed a commit that referenced this issue Jan 17, 2022
Remove remaining girder API stuff
@yarikoptic
Copy link
Member

related issue: dandi/dandi-schema#115 in which I argue against license selection for embargoed dandisets, and have that selection at Unemabrgo point.

@mvandenburgh
Copy link
Member

This was completed in #839.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UX Affects usability of the system
Projects
None yet
Development

No branches or pull requests

4 participants