Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dandi download redownloads entire Dandiset when run within Dandiset directory #1468

Open
kabilar opened this issue Jul 23, 2024 · 1 comment
Labels

Comments

@kabilar
Copy link
Member

kabilar commented Jul 23, 2024

Use case

In the following use case, the DANDI Client is working as intended, but I would propose that the functionality may not always match user behavior. It is a bit confusing to describe this use case, so let me know if you need further clarification. Thank you.

  1. A user wants to edit file(s) of a Dandiset that exists locally and then upload the edited files.
  2. Since they have the Dandiset locally, the observed behavior is to change the current working directory to within the Dandiset directory (i.e. cd ~/dataset_id).
  3. They then may run dandi download <url> to pull down the latest files from collaborators, edit files locally, and then run dandi upload.
  4. This workflow actually downloads the entire Dandiset again creating a new tree within the current working directory (i.e. ~/dataset_id). The workaround would be to change into the parent directory or the add the option -o ...

Possible solution

  1. If a user runs dandi download <url> within a directory that has a corresponding dandiset.yaml file, perhaps the DANDI Client can run a check and update the existing Dandiset directory?

cc @aaronkanzer @kilimanjaro2

@yarikoptic
Copy link
Member

how do we know that it is not user wanting to add some (entire) other dandiset inside this dandiset? (may be by downloading and then mv). If user points to some url I guess it is ok to assume that that url is intended to be downloaded, even may be into a wrong location and then mv'ed . So I do not think it is worth "over-protecting" here.

@yarikoptic yarikoptic added the UX label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants