Fix shellcheck warnings in *-ec2.sh

- Separate variable declaration and assignment to avoid masking return values (SC2155)
- Add shellcheck disable comment for SC1090 (fixed by a human - gave wrong instructions, claude did to wrong file)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: yarikoptic

.github/scripts/cleanup-ec2.sh

@@ -6,6 +6,7 @@ set -eu
 ENV_FILE=".ec2-session.env"
 if [ -f "$ENV_FILE" ]; then
   echo "Loading environment variables from $ENV_FILE..."
+  # shellcheck disable=SC1090
   source "$ENV_FILE"
 else
   echo "Warning: Environment file $ENV_FILE not found."

.github/scripts/launch-ec2.sh

@@ -36,7 +36,7 @@ echo "# Auto-generated by launch script on $(date)" >> $ENV_FILE
 
 # Run EC2 instance
 echo "Launching EC2 instance..."
-export INSTANCE_ID=$(aws ec2 run-instances \
+INSTANCE_ID=$(aws ec2 run-instances \
   --image-id $AMI_ID \
   --count 1 \
   --instance-type t3.micro \
@@ -46,6 +46,7 @@ export INSTANCE_ID=$(aws ec2 run-instances \
   --tag-specifications "ResourceType=instance,Tags=[{Key=Name,Value=dandihub-gh-actions}]" \
   --query 'Instances[0].InstanceId' \
   --output text)
+export INSTANCE_ID
 
 if [ -z "$INSTANCE_ID" ]; then
   echo "Error: Failed to launch EC2 instance."
@@ -60,10 +61,11 @@ aws ec2 wait instance-status-ok --instance-ids "$INSTANCE_ID"
 
 # Allocate Elastic IP
 echo "Allocating Elastic IP..."
-export ALLOC_ID=$(aws ec2 allocate-address \
+ALLOC_ID=$(aws ec2 allocate-address \
   --tag-specifications "ResourceType=elastic-ip,Tags=[{Key=Name,Value=dandihub-gh-actions-eip}]" \
   --query 'AllocationId' \
   --output text)
+export ALLOC_ID
 
 if [ -z "$ALLOC_ID" ]; then
   echo "Error: Failed to allocate Elastic IP."
@@ -74,22 +76,24 @@ echo "export ALLOC_ID=$ALLOC_ID" >> $ENV_FILE
 
 # Associate Elastic IP with instance
 echo "Associating Elastic IP with instance..."
-export EIP_ASSOC=$(aws ec2 associate-address \
+EIP_ASSOC=$(aws ec2 associate-address \
   --instance-id "$INSTANCE_ID" \
   --allocation-id "$ALLOC_ID" \
   --query 'AssociationId' \
   --output text)
+export EIP_ASSOC
 
 if [ -z "$EIP_ASSOC" ]; then
   echo "Error: Failed to associate Elastic IP."
   exit 1
 fi
 
 # Get Elastic IP address
-export PUBLIC_IP=$(aws ec2 describe-addresses \
+PUBLIC_IP=$(aws ec2 describe-addresses \
   --allocation-ids "$ALLOC_ID" \
   --query 'Addresses[0].PublicIp' \
   --output text)
+export PUBLIC_IP
 
 echo "Elastic IP Address: $PUBLIC_IP"
 echo "export PUBLIC_IP=$PUBLIC_IP" >> $ENV_FILE