Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workflow that reports back to a PR whether schema has changed #122

Open
satra opened this issue Mar 4, 2022 · 3 comments
Open

add workflow that reports back to a PR whether schema has changed #122

satra opened this issue Mar 4, 2022 · 3 comments

Comments

@satra
Copy link
Member

satra commented Mar 4, 2022

It would be good to just add a PR bot that checks schema change and reports back to a PR. we often check on this by turning release label on and then turning it off.

@yarikoptic
Copy link
Member

try removing this line
https://github.com/dandi/dandischema/blob/HEAD/.github/workflows/test-schema.yml#L11
if that is what you are looking for ?

@satra
Copy link
Member Author

satra commented Apr 5, 2022

it would be a combination of that if and the exitcode later in the workflow. we don't want the test to fail, but just inform that a new schema release may be necessary with the PR.

@satra
Copy link
Member Author

satra commented Apr 5, 2022

perhaps using something like this: https://github.com/marketplace/actions/add-pr-comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants