-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for local deployment #63
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me overall. Leaving this as a comment rather than an approval so someone with more authority on this repo (I think that's @yarikoptic?) can weigh in.
--volume="$PWD/vendor/bundle:/usr/local/bundle" \ | ||
--env JEKYLL_ENV=development -p 4000:4000 \ | ||
jekyll/jekyll:4.0.1 jekyll serve --config _config.yml | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running from top directory on Linux I got
❯ docker run --rm -it --volume="$PWD:/srv/jekyll" \
--volume="$PWD/vendor/bundle:/usr/local/bundle" \
--env JEKYLL_ENV=development -p 4000:4000 \
jekyll/jekyll:4.0.1 jekyll serve --config _config.yml
Unable to find image 'jekyll/jekyll:4.0.1' locally
4.0.1: Pulling from jekyll/jekyll
cbdbe7a5bc2a: Pull complete
aa8ae8202b42: Pull complete
b21786fe7c0d: Pull complete
2e8deee27474: Pull complete
b84a6ba69f44: Pull complete
593a81637df6: Pull complete
Digest: sha256:2500fafd64afad32e40295c23a7054d95be95b2cf5b76b285af2a2149e2d9322
Status: Downloaded newer image for jekyll/jekyll:4.0.1
Could not locate Gemfile
❯ find -iname Gemfile
./Gemfile
find: ‘./.sass-cache’: Permission denied
find: ‘./_site’: Permission denied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the docker command needs a working directory flag to be in /srv/jekyll
last week github pages wouldn't build because of a bug. it looks like it's been released, and the gemfile should simply contain. this should keep any local dev consistent with github's page build mechanism
alternatively, one could in the future, switch to actions from pages (https://github.com/sensein/sensein.github.io/blob/main/.github/workflows/pages-build.yml), which i did last week because of the bug. an action also gives more capabilities, like using jekyll 4, if needed. |
also the |
docker run
command for local deployment