Skip to content

Make resource-fetching methods of clients return DavResource[WithChildren] objects #165

@jwodder

Description

@jwodder
  • The following methods should be modified to return DavResource or DavResourceWithChildren objects, as appropriate:

    • DandiClient::get_all_dandisets()
    • DandisetEndpoint::get()
    • DandisetEndpoint::get_all_versions()
    • VersionEndpoint::get()
    • VersionEndpoint::get_metadata()
    • VersionEndpoint::get_resource()
    • VersionEndpoint::get_resource_with_children()
    • VersionEndpoint::get_root_children()
    • ZarrManClient::get_top_level_dirs()
    • ZarrManClient::get_resources()
    • ZarrManClient::get_resources_with_children()
  • The types that the above methods currently return should all have their visibilities restricted to crate::dandi or crate::zarrman, as appropriate

  • Various types in src/zarrman/resources.rs should then be renamed for greater accuracy (made easier by the fact that these types no longer have to coexist alongside crate::dandi types):

    • ManifestZarr
    • ManifestFolderZarrFolder
    • ManifestEntryZarrEntry

    and likewise for enum variants

Metadata

Metadata

Assignees

No one assigned

    Labels

    code qualityNonfunctional improvements to the codebasehigh priorityWork on these first

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions