Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject PROPFIND requests with external entities with a no-external-entities precondition #36

Open
jwodder opened this issue Jan 30, 2024 · 2 comments
Labels
correctness Getting it right low priority Less important than other things WebDAV Specific to the WebDAV protocol/implementation

Comments

@jwodder
Copy link
Member

jwodder commented Jan 30, 2024

RFC 4918 requires that when a PROPFIND request contains any XML external entities and the server rejects it as a result, the rejection should be a 403 response of the form:

<?xml version="1.0" encoding="utf-8"?>
<error xmlns="DAV:">
    <no-external-entities />
</error>
@jwodder jwodder added correctness Getting it right low priority Less important than other things WebDAV Specific to the WebDAV protocol/implementation labels Jan 30, 2024
@yarikoptic
Copy link
Member

did we encounter any of such, e.g. as triggered by rclone or some other FUSE system?

@jwodder
Copy link
Member Author

jwodder commented Feb 14, 2024

@yarikoptic I don't believe so. The only clients that would ever send bodies with external entities would be malicious. At the moment, it seems that the xml-rs library that dandidav uses for parsing XML simply ignores any external entities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correctness Getting it right low priority Less important than other things WebDAV Specific to the WebDAV protocol/implementation
Projects
None yet
Development

No branches or pull requests

2 participants