Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error_on_change can be "racy" #246

Open
yarikoptic opened this issue Aug 11, 2022 · 0 comments
Open

error_on_change can be "racy" #246

yarikoptic opened this issue Aug 11, 2022 · 0 comments

Comments

@yarikoptic
Copy link
Member

yarikoptic commented Aug 11, 2022

NB I hit Enter my accident before filling it in

This is a follow up to #245 PR which introduces default behavior of quick checks of dandisets by their modification times to decide either to skip or go through assets and reflect changes. In the mode of --verify-timestamps it might happen that we would be going through assets while dandiset gets updated, and by the time we get to some asset the done previously check based solely on date would no longer be valid. So I think that may be error_on_change should actually be a callback/fixture for a specific dandiset to re-ask that dandiset modification datetime, so if we detected some change, and see that modification time did change from previous one -- we are all good an do not need to error out on that run for that or any subsequent check like that.

Since situation is still hypothetical, I decided to just file an issue instead of requesting changes to that PR. But if you @jwodder think it is worthwhile implementing right there -- go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant