Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proper cleanup of temporary directory #25

Closed
jwodder opened this issue Nov 19, 2024 · 1 comment
Closed

Ensure proper cleanup of temporary directory #25

jwodder opened this issue Nov 19, 2024 · 1 comment

Comments

@jwodder
Copy link
Member

jwodder commented Nov 19, 2024

The temporary directory used by S3Client for downloading manifests and inventory lists should be deleted automatically on program exit, but this is not happening (when Ctrl-C is pressed, at least). The tempfile docs suggest that File handles or similar might not be getting dropped before the TempDir. Fix this.

@jwodder
Copy link
Member Author

jwodder commented Nov 19, 2024

Further investigation indicates that the temporary directory is cleaned up appropriately on normal (non-Ctrl-C) exit, so this is only a problem when Ctrl-C is hit, which we can't do much about at the moment (but see #14).

@jwodder jwodder closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant