-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light Screen Icons #171
Comments
As you can seen the image, a couple of icons are missing |
Which icons are missing? I've just tried this myself at |
Are you hosting the project yourself in a dev environment, or using the production version at profileme.dev? There seems to be a link between how the project is deployed and how some image links are generated, at least for the social ones. I'm still getting familiar with how it works. |
I'm using profileme.dev |
I see the issue you're experiencing now, it isn't that the social icons are missing (that's another issue), but instead it's the fact that the markdown content only generates for one colour-scheme for skill icons based on whether you choose light or dark mode in the preview. If you choose dark mode in the profileme.dev preview, then apply to github and set your preference to light mode, some icons will be indistinguishable from the background. It does the correct behaviour for the socials where it includes the |
Oh, thanks. will definitely be on the look out for that! |
There's still a fix here worth doing to address the issue. :) |
Could you maybe share, @LachyTech ?? |
I've just pushed a PR to address the issue. Not sure how long it will take to get reviewed and accepted, but you can deploy manually to get the output now if you need to. |
Cool, thanks @LachyTech |
I have a question and an inquiry. When I am in light mode, some icons are missing, but everything appears fine in dark mode. Did I set something up incorrectly, or is this a feature that doesn’t exist yet?
The text was updated successfully, but these errors were encountered: