Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Screen Icons #171

Open
FREDVUNI opened this issue Aug 9, 2024 · 11 comments
Open

Light Screen Icons #171

FREDVUNI opened this issue Aug 9, 2024 · 11 comments

Comments

@FREDVUNI
Copy link

FREDVUNI commented Aug 9, 2024

I have a question and an inquiry. When I am in light mode, some icons are missing, but everything appears fine in dark mode. Did I set something up incorrectly, or is this a feature that doesn’t exist yet?
Screenshot 2024-08-09 155354

@FREDVUNI
Copy link
Author

FREDVUNI commented Aug 9, 2024

As you can seen the image, a couple of icons are missing

@LachyTech
Copy link

Which icons are missing? I've just tried this myself at 3fc3595593bc992e6febba6580d6c9571f5e625f using npm run dev and didn't encounter any issues with icons.

@FREDVUNI
Copy link
Author

In dark mode, they all appear
image

Icons missing:
Next JS, Babel, Django, XD and Git hub

@LachyTech
Copy link

Are you hosting the project yourself in a dev environment, or using the production version at profileme.dev?

There seems to be a link between how the project is deployed and how some image links are generated, at least for the social ones. I'm still getting familiar with how it works.

@FREDVUNI
Copy link
Author

I'm using profileme.dev

@LachyTech
Copy link

LachyTech commented Aug 20, 2024

I see the issue you're experiencing now, it isn't that the social icons are missing (that's another issue), but instead it's the fact that the markdown content only generates for one colour-scheme for skill icons based on whether you choose light or dark mode in the preview. If you choose dark mode in the profileme.dev preview, then apply to github and set your preference to light mode, some icons will be indistinguishable from the background.

It does the correct behaviour for the socials where it includes the <source media="(prefers-color-scheme: dark)" tags, so we'd need to do something similar for skill icons where the path/darkPath attributes are set.

Light mode on github:
image

Dark mode on github:
image

@FREDVUNI
Copy link
Author

Oh, thanks. will definitely be on the look out for that!

@LachyTech
Copy link

There's still a fix here worth doing to address the issue. :)

@FREDVUNI
Copy link
Author

Could you maybe share, @LachyTech ??

@LachyTech
Copy link

I've just pushed a PR to address the issue. Not sure how long it will take to get reviewed and accepted, but you can deploy manually to get the output now if you need to.

@FREDVUNI
Copy link
Author

Cool, thanks @LachyTech

@FREDVUNI FREDVUNI reopened this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants