Fix Books.md template: restore 'Daniel Kahneman' as the book author - #1696
Closed
anikinsasha wants to merge 1 commit into
Closed
Fix Books.md template: restore 'Daniel Kahneman' as the book author#1696anikinsasha wants to merge 1 commit into
anikinsasha wants to merge 1 commit into
Conversation
The {{PRINCIPAL_NAME}} placeholder substitution caught the author's first
name, so every install renders the line as '<principal> Kahneman'
(e.g. 'Alice Kahneman'). Only content-level placeholder hit in the payload:
grep -rP '\{\{PRINCIPAL_NAME\}\} [A-Z][a-z]+' LifeOS/install returns
this one line.
Owner
|
Thanks @anikinsasha — Kahneman is already restored in the current source, so this one is in hand. Closing here since the public repo is generated from that source; it'll be in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
{{PRINCIPAL_NAME}}placeholder substitution caught the author's first name in the Books starter template, so every install renders line 17 as<principal name> Kahneman(e.g. "Alice Kahneman") in the suggested-reading list.Before:
- **Thinking, Fast and Slow** — {{PRINCIPAL_NAME}} KahnemanAfter:
- **Thinking, Fast and Slow** — Daniel KahnemanThis is the only content-level placeholder hit in the payload —
grep -rP '\{\{PRINCIPAL_NAME\}\} [A-Z][a-z]+' LifeOS/installreturns just this line ({{DA_NAME}} has no equivalent hits).