fix some clippy lints and update CI workflow

This fixes some clippy lints in the tests and updates the CI
workflow to use --all-targets with clippy, error out on doc
failures, and use checkout@v4.

Signed-off-by: Daniel Estévez <[email protected]>

Author: daniestevez

.github/workflows/rust.yml

@@ -10,13 +10,13 @@ jobs:
     name: Default features
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Format
       run: cargo fmt --all -- --check
     - name: Clippy
-      run: cargo clippy -- -D warnings
+      run: cargo clippy --all-targets -- -D warnings
     - name: Doc
-      run: cargo doc
+      run: RUSTDOCFLAGS="-D warnings" cargo doc
     - name: Build
       run: cargo build --verbose
     - name: Run tests
@@ -26,13 +26,13 @@ jobs:
     name: No features
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Format
       run: cargo fmt --all -- --check
     - name: Clippy
-      run: cargo clippy --no-default-features -- -D warnings
+      run: cargo clippy --all-targets --no-default-features -- -D warnings
     - name: Doc
-      run: cargo doc
+      run: RUSTDOCFLAGS="-D warnings" cargo doc
     - name: Build
       run: cargo build --no-default-features --verbose
     - name: Run tests

src/bbframe.rs

@@ -676,7 +676,7 @@ mod test {
          30 31 32 33 34 35 36 37"
     );
 
-    static MULTIPLE_FRAGMENTS: [&'static [u8]; 3] = [&FRAGMENT0, &FRAGMENT1, &FRAGMENT2];
+    static MULTIPLE_FRAGMENTS: [&[u8]; 3] = [&FRAGMENT0, &FRAGMENT1, &FRAGMENT2];
 
     #[test]
     fn single_fragment_defrag() {
@@ -861,7 +861,7 @@ mod proptests {
             // twice in order to flush a partial BBHEADER left
             // by the garbage.
             assert!(times_called.get() <= garbage_data.len() + 2);
-            if times_called.get() >= garbage_data.len() + 1 {
+            if times_called.get() > garbage_data.len() {
                 assert_eq!(bbframe, Bytes::from_static(&SINGLE_FRAGMENT));
             }
         }
@@ -894,7 +894,7 @@ mod proptests {
             while times_called.get() <= garbage_data.len() {
                 if let Ok(bbframe) = recv.get_bbframe() {
                     assert!(times_called.get() <= garbage_data.len() + 1);
-                    if times_called.get() >= garbage_data.len() + 1 {
+                    if times_called.get() > garbage_data.len() {
                         assert_eq!(bbframe, Bytes::from_static(&SINGLE_FRAGMENT));
                     }
                 }

src/gseheader.rs

@@ -539,7 +539,8 @@ mod proptests {
                 header.protocol_type();
                 if let Some(label) = header.label() {
                     label.as_slice();
-                    assert_eq!(label.is_empty(), label.len() == 0);
+                    let len = label.len();
+                    assert_eq!(label.is_empty(), len == 0);
                 }
                 assert!(header.len() >= 3);
                 assert!(!header.is_empty());

src/gsepacket.rs

@@ -379,7 +379,7 @@ mod proptests {
         fn defrag_garbage(garbage_bbframes in garbage()) {
             let mut defrag = GSEPacketDefrag::new();
             for bbframe in &garbage_bbframes {
-                if let Ok(pdus) = defrag.defragment(&bbframe) {
+                if let Ok(pdus) = defrag.defragment(bbframe) {
                     for pdu in pdus {
                         pdu.data();
                         pdu.protocol_type();