-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update comments on review re-submit #37
Comments
In-place edit sounds a bit complicated to implement. There's probably quite a bit of state to keep track of to accomplish this. It would also conflict with the ability to add multiple comments in the same place (in two separate submits). On a higher level, it's not quite mailing list like. For example, once you send an email you cannot really take it back and edit it. On the other hand, I could be convinced idempotency would be worthwhile to add. So that you duplicates don't get uploaded. |
If no edits (fine), then it might make sense to:
|
Also, to be clear, I do not need this feature or tool for anything critical! I only discovered it today and it seems neat and like something I would use, and I tried to submit a feature issue like the others already in the repo. I am not trying to ask for a bunch of work for free. |
No worries, all feedback is welcome! |
If I write a review, submit it, and then go update the review file, a new submit will create comments all over again. Ideally I would be able to update the existing comments in place.
The text was updated successfully, but these errors were encountered: