Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update comments on review re-submit #37

Open
tekknolagi opened this issue Dec 11, 2023 · 4 comments
Open

feat: Update comments on review re-submit #37

tekknolagi opened this issue Dec 11, 2023 · 4 comments

Comments

@tekknolagi
Copy link
Contributor

If I write a review, submit it, and then go update the review file, a new submit will create comments all over again. Ideally I would be able to update the existing comments in place.

@danobi
Copy link
Owner

danobi commented Dec 12, 2023

In-place edit sounds a bit complicated to implement. There's probably quite a bit of state to keep track of to accomplish this. It would also conflict with the ability to add multiple comments in the same place (in two separate submits). On a higher level, it's not quite mailing list like. For example, once you send an email you cannot really take it back and edit it.

On the other hand, I could be convinced idempotency would be worthwhile to add. So that you duplicates don't get uploaded.

@tekknolagi
Copy link
Contributor Author

If no edits (fine), then it might make sense to:

  • Delete PR text once submitted (or at least rename it)
  • Provide a way to render the whole thread in mailing list format
  • Provide a way to transform edits to the full thread into new comments

@tekknolagi
Copy link
Contributor Author

Also, to be clear, I do not need this feature or tool for anything critical! I only discovered it today and it seems neat and like something I would use, and I tried to submit a feature issue like the others already in the repo. I am not trying to ask for a bunch of work for free.

@danobi
Copy link
Owner

danobi commented Dec 12, 2023

No worries, all feedback is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants