Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic CI improvements #41

Open
danobi opened this issue Dec 17, 2023 · 0 comments
Open

Generic CI improvements #41

danobi opened this issue Dec 17, 2023 · 0 comments

Comments

@danobi
Copy link
Owner

danobi commented Dec 17, 2023

From: #40 (review)

Couple of nice-to-have things:

  • That's highly controversial opinion, but I personally prefer cargo fmt to be triggered by cargo test, rather than by my CI, so that I can run cargo test local and not worry about some checks which are there on the CI but are missing locally. The same applies to static linking --- if I am worried about being able to statically link, I'd probably write an integration tests for this which shells out to cargo, rather than leaving this logic to a .yml in CI.
  • default caching on CI is pretty bad, https://github.com/Swatinem/rust-cache/actions is a big improvement if you care about CI times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant