Skip to content

Commit 61efae5

Browse files
committed
Re-implement WidgetPlaceholder.firstChild usage
1 parent f01a002 commit 61efae5

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

lib/src/widgets/html.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ import 'dart:convert';
55
import 'package:flutter/material.dart';
66
import 'package:flutter_cache_manager/flutter_cache_manager.dart';
77
import 'package:flutter_widget_from_html/flutter_widget_from_html.dart';
8+
// ignore: implementation_imports
9+
import 'package:flutter_widget_from_html_core/src/internal/core_ops.dart'
10+
show Priority;
811
import 'package:fwfh_webview/fwfh_webview.dart';
912
import 'package:html_unescape/html_unescape.dart';
1013
import 'package:http/http.dart';

lib/src/widgets/html/photo_compare.dart

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,15 @@ class PhotoCompare {
1515
subTree.register(
1616
BuildOp(
1717
onRenderBlock: (_, placeholder) {
18-
final child = placeholder.firstChild;
19-
if (child != null) {
20-
final value = tree.getNonInherited<_Images>();
21-
if (value == null) {
22-
tree.setNonInherited(_Images([child]));
23-
} else {
24-
value.widgets.add(child);
25-
}
18+
final value = tree.getNonInherited<_Images>();
19+
if (value == null) {
20+
tree.setNonInherited(_Images([placeholder]));
21+
} else {
22+
value.widgets.add(placeholder);
2623
}
27-
return placeholder;
24+
return widget0;
2825
},
29-
priority: 5000000000000000, // Priority._baseBoxModel
26+
priority: Priority.tagImg + 1,
3027
),
3128
);
3229
}

pubspec.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ packages:
438438
source: hosted
439439
version: "0.14.11"
440440
flutter_widget_from_html_core:
441-
dependency: transitive
441+
dependency: "direct main"
442442
description:
443443
name: flutter_widget_from_html_core
444444
sha256: "028f4989b9ff4907466af233d50146d807772600d98a3e895662fbdb09c39225"

pubspec.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ dependencies:
1616

1717
# ours
1818
flutter_widget_from_html: ^0.14.11
19+
flutter_widget_from_html_core: any
1920
fwfh_webview: any
2021
the_api:
2122
path: ./packages/api

0 commit comments

Comments
 (0)