fallback C.simplify ir_version error to C.simplify_path #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daquexian
approved these changes
Jul 8, 2024
triple-Mu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix onnxsim about simplifying larger than 2G onnx model.
It will raise an error in
C.simplify:onnx.onnx_cpp2py_export.checker.ValidationError: The model does not have an ir_version set properly.And it cannot be solved by downgrading the version of onnx/onnxsim/protobuf.
But we can catch this exception and treat it as equivalent to a value error about exceeding 2GB.
Then
C.simplify_pathworks well now.