Skip to content
This repository has been archived by the owner on Nov 3, 2020. It is now read-only.

Compile with --strict #111

Open
darkf opened this issue Dec 17, 2017 · 2 comments
Open

Compile with --strict #111

darkf opened this issue Dec 17, 2017 · 2 comments

Comments

@darkf
Copy link
Owner

darkf commented Dec 17, 2017

To ensure the code's type coverage is high and there aren't any obvious lurking bugs due to subversive type errors, we should be compiling with tsc's --strict mode (which turns on all safety options.)

As of now, we can and do compile with --noImplicitAny which is a big part of it.

However, the next biggest part will be --noImplicitThis, mainly due to requiring a proper this type on procedures in scripting.
Unfortunately it cannot be ScriptProto as it would be circularly defined.

@darkf
Copy link
Owner Author

darkf commented Jan 2, 2018

ScriptProto is now gone in the scriptclass branch, and it compiles cleanly with --noImplicitThis.

The biggest thing left is --strictNullChecks which is rather annoying.

@darkf
Copy link
Owner Author

darkf commented Aug 19, 2018

Did some more work on --strictNullChecks tonight, there are still about 120 errors left... Some of them are more involved than the others, so there might be something like 40 left that won't be done for a while.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant