Skip to content
This repository has been archived by the owner on Nov 3, 2020. It is now read-only.

Test/fix [Done] dialogue #118

Open
darkf opened this issue Dec 24, 2017 · 1 comment
Open

Test/fix [Done] dialogue #118

darkf opened this issue Dec 24, 2017 · 1 comment

Comments

@darkf
Copy link
Owner

darkf commented Dec 24, 2017

In scripting.ts, we have:

$("#dialogue").append("&nbsp;&nbsp;\"" + msg + "\"<br><a href=\"javascript:dialogueEnd()\">[Done]</a><br>")

But #dialogue no longer exists, it was replaced. Earlier we have for normal replies:

			//$("#dialogue").append("&nbsp;&nbsp;\"" + msg + "\"<br>")
			uiSetDialogueReply(msg)

So we replaced it and the UI module now handles it, but it looks like [Done] options were never ported over.

It was added in 3fe7d5d.

jQuery was obscuring the selector failing.

I can't think off the top of my head what a good map to test this would be.

@darkf
Copy link
Owner Author

darkf commented Dec 24, 2017

It looks like there's some other archaic cruft in there, like endBarter (unused).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant