Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other jpeg encoders like jpegli or mozjpeg #17544

Open
Today20092 opened this issue Sep 27, 2024 · 2 comments
Open

Add other jpeg encoders like jpegli or mozjpeg #17544

Today20092 opened this issue Sep 27, 2024 · 2 comments

Comments

@Today20092
Copy link

Is your feature request related to a problem? Please describe.

We should be able so specific what JPEG encoder to use.

Describe the solution you'd like

An option when exporting jpegs to be able choose the encoder.

Alternatives

None for this feature. Or just fully switch to jpegli for better compression efficiency.

Additional context

@kmilos
Copy link
Contributor

kmilos commented Sep 27, 2024

FYI:

https://repology.org/project/jpegli/versions (spread of only 1 currently)

https://repology.org/project/libjpeg-turbo/versions (spread of 57)

Bit of a chicken and egg situation unfortunately...

P.S. mozjpeg has a spread of 14, but doesn't make sense as an alternative as much as jpegli does for its other extra features (just the small space saving is not worth the effort IMHO)

@victoryforce
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

We should be able so specific what JPEG encoder to use.

Describe the solution you'd like

An option when exporting jpegs to be able choose the encoder.

This is not a good solution:

  • If jpegli is clearly better than libjpeg-turbo, then why build with both and give a choice?
  • The user is not required to know any JPEG encoders and their characteristics and forcing the user to choose is a bad idea.

Alternatives

None for this feature. Or just fully switch to jpegli for better compression efficiency.

As soon as jpegli gets at least the first stable release, will have production quality and will be available in distributions. Before that, there is no point in talking about it as an existing library.

Because of the above, I see no point in keeping this issue open. When the time comes, of course darktable will switch to the best encoder available on supported platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants