Merge pull request #635 from kmilos/kmilos/dng_float_white

LebedevRI · web-flow · commit a9a8880d5360 · 2024-01-31T16:38:06.000+03:00
DngDecoder: use uninitialized white point value for float DNGs
diff --git a/src/librawspeed/decoders/DngDecoder.cpp b/src/librawspeed/decoders/DngDecoder.cpp
@@ -603,7 +603,8 @@ void DngDecoder::handleMetadata(const TiffIFD* raw) {
     mRaw->whitePoint = implicit_cast<int>((1UL << bps) - 1UL);
   } else if (mRaw->getDataType() == RawImageType::F32) {
     // Default white level is 1.0f. But we can't represent that here.
-    mRaw->whitePoint = 65535;
+    // Fall back to uninitialized value instead.
+    mRaw->whitePoint = 65536;
   }
 
   if (raw->hasEntry(TiffTag::WHITELEVEL)) {

Original file line number	Diff line number	Diff line change
`@@ -603,7 +603,8 @@ void DngDecoder::handleMetadata(const TiffIFD* raw) {`
`603`	`603`	`mRaw->whitePoint = implicit_cast<int>((1UL << bps) - 1UL);`
`604`	`604`	`} else if (mRaw->getDataType() == RawImageType::F32) {`
`605`	`605`	`// Default white level is 1.0f. But we can't represent that here.`
`606`		`- mRaw->whitePoint = 65535;`
	`606`	`+ // Fall back to uninitialized value instead.`
	`607`	`+ mRaw->whitePoint = 65536;`
`607`	`608`	`}`
`608`	`609`
`609`	`610`	`if (raw->hasEntry(TiffTag::WHITELEVEL)) {`