Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix use of fixed width fonts in the console #2980

Merged
merged 2 commits into from
Jun 4, 2024
Merged

fix use of fixed width fonts in the console #2980

merged 2 commits into from
Jun 4, 2024

Conversation

devoncarew
Copy link
Member

Screenshot 2024-06-04 at 1 13 19 PM
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

parlough
parlough approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice!

@devoncarew devoncarew merged commit dc44acd into main Jun 4, 2024
4 checks passed
@devoncarew devoncarew deleted the fixed_fonts branch June 4, 2024 22:09
@devoncarew
Copy link
Member Author

It looks like there's some additional wiring needed here:

Error: google_fonts was unable to load font RobotoMono-Regular because the following exception occurred:
Exception: GoogleFonts.config.allowRuntimeFetching is false but font RobotoMono-Regular was not found in the application assets. Ensure RobotoMono-Regular.ttf exists in a folder that is included in your pubspec's assets.

@devoncarew devoncarew mentioned this pull request Jun 4, 2024
Closed
1 task
@parlough parlough mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error output should use monospace font
2 participants
@devoncarew @parlough