Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Instance variable section of Classes page #5824

Closed
1 task
mattrberry opened this issue May 14, 2024 · 1 comment · Fixed by #5849
Closed
1 task

Fix typo in Instance variable section of Classes page #5824

mattrberry opened this issue May 14, 2024 · 1 comment · Fixed by #5849
Assignees
@MaryaBelanger
Labels
a.language Relates to the Dart language tour e0-minutes Can complete in < 60 minutes of normal, not dedicated, work fix.typo Fixes small copy or image errors from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged

Comments

@mattrberry
Copy link
Contributor

Page URL

https://dart.dev/language/classes#instance-variables

Page source

No response

Describe the problem

Introduced in #5310, the section on "instance variables" (and the other file modified in that PR) references missing this.fieldName in the comment. I'd have fixed this myself, but honestly I'm not sure what the comment is trying to indicate is "OK" even after looking through the commit history on that PR. I figured I'd leave removing or updating the comment to somebody else

Expected fix

No response

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on dart.dev.
@mattrberry mattrberry added the from.page-issue Reported in a reader-filed concern label May 14, 2024
@atsansone atsansone added a.language Relates to the Dart language tour p2-medium Necessary but not urgent concern. Resolve when possible. e0-minutes Can complete in < 60 minutes of normal, not dedicated, work st.triage.ltw Indicates Lead Tech Writer has triaged fix.typo Fixes small copy or image errors labels May 15, 2024
@atsansone atsansone changed the title Instance variable docs have a typo Fix typo in Instance variable section of Classes page May 15, 2024
@MaryaBelanger MaryaBelanger mentioned this issue May 20, 2024
Merged
@MaryaBelanger
Copy link
Contributor

I think I intended that this.fieldName be a place holder for this.x and this.y, but I can see now that that's pretty confusing so thanks for pointing it out @mattrberry!

MaryaBelanger added a commit that referenced this issue May 30, 2024
@MaryaBelanger
Clarify confusing wording in Classes > Instance variables (#5849)
008db87 
Fixes #5824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaryaBelanger MaryaBelanger

Labels
a.language Relates to the Dart language tour e0-minutes Can complete in < 60 minutes of normal, not dedicated, work fix.typo Fixes small copy or image errors from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify confusing wording in Classes > Instance variables dart-lang/site-www
3 participants
@atsansone @mattrberry @MaryaBelanger