Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint saving may be not appropriate. #21

Open
feiaa opened this issue Feb 25, 2018 · 0 comments
Open

Checkpoint saving may be not appropriate. #21

feiaa opened this issue Feb 25, 2018 · 0 comments

Comments

@feiaa
Copy link

feiaa commented Feb 25, 2018

In your code:

        if best < test_pearson:
            best = test_pearson
            checkpoint = {
                'model': trainer.model.state_dict(), 
                'optim': trainer.optimizer,
                'pearson': test_pearson, 'mse': test_mse,
                'args': args, 'epoch': epoch
                }
            logger.debug('==> New optimum found, checkpointing everything now...')
            torch.save(checkpoint, '%s.pt' % os.path.join(args.save, args.expname))

The test_pearson is used instead of dev_pearson and the test_pearson should not be used to choose your best model.
I got test result (Pearson: 0.8616 MSE: 0.2626) which had the highest dev_pearson score.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant