chore: adopt zero-cost grove v4 gates and restore released fee constants

Bumps grovedb to develop b5bd7ef, which makes the v4 cleanup gates
derive their inspection from data the merk apply already loads
(dashpay/grovedb#790, on top of the estimator parity in #789). The
gates keep their semantics — indexed-tree overwrite/delete-tree cleanup
— at zero marginal cost, so every fee constant returns to its released
value and the protocol v13/v14 test pairs now assert identical fees
across the boundary. The ranked-trees book chapter's cost section is
rewritten accordingly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: QuantumExplorer

Cargo.lock

@@ -244,11 +244,11 @@ Indexed trees need two batch behaviours that earlier grove versions don't have,
 
 Without them, a batch overwrite of a ranked index would orphan its per-axis secondary storage. Indexed trees only exist from protocol v14, so activating the stricter cleanup alongside them costs older versions nothing.
 
-Both gates cost **one extra stored-element read per overwrite-capable operation** — which is why they could not be applied to released versions, and why v14's fee constants move. The shape of the change is worth internalising because it is easy to misread as a general fee increase:
+Both gates are **cost-neutral**: they derive the old element from data the merk apply already loads when it rewrites or deletes a key, so no extra stored-element read is charged and v14's fee constants match v13's. Three facts pin this:
 
-- **Fresh-key inserts pay nothing extra.** There is no stored element to inspect. In the address-funds-transfer fee regression suite the pins for simple single-input/single-output transfers, multisig spends and the user-fee-increase case are all **unchanged**; only the cases that overwrite existing keys move.
-- **Gated operations pay one stored-element read each: a seek (2 000 credits) plus 20 credits per byte of the element loaded** — so the delta varies with the size of the element at the overwritten key. The identity-balance and token-balance update pins both move by `+4 300` processing credits (`385 160 → 389 460`, `260 540 → 264 840`): one seek plus a 115-byte element. Storage fees are unchanged throughout — the delta is pure read cost.
-- **The boundary itself is pinned.** `run_chain_one_identity_in_solitude` sits exactly **2 000 credits** below its new protocol-version-13 sibling, which asserts the pre-grove-v4 figure — the gate cost for that run's single gated operation. The pair brackets the v13 → v14 transition, so a future change that moves either side has to say which one it meant to move.
+- **Fees are identical across the boundary.** The identity-balance, token-balance and state-transition processing-fee pins carry the same values at protocol v13 and v14, and `run_chain_one_identity_in_solitude` has a protocol-version-13 sibling asserting the identical end balance — the pair proves the v13 → v14 transition changes nothing about those runs' fees.
+- **Storage fees are untouched everywhere** — the gates only observe, never write.
+- **Cleanup still happens.** A batch overwrite of an indexed tree schedules its per-axis secondary storage for cleanup (or refuses the ambiguous case), and `DeleteTree` uses the actual stored type — covered by grovedb's own overwrite and delete-tree suites at the pinned revision.
 
 ## Interaction With the Shared-Prefix Aggregate Fix
 

book/src/drive/document-ranked-trees.md

@@ -71,7 +71,7 @@ strum = { version = "0.26", features = ["derive"] }
 json-schema-compatibility-validator = { path = '../rs-json-schema-compatibility-validator', optional = true }
 once_cell = "1.19.0"
 tracing = { version = "0.1.41" }
-grovedb-commitment-tree = { git = "https://github.com/dashpay/grovedb", rev = "d473818154dac668676fcb54678287845032d9a7", optional = true }
+grovedb-commitment-tree = { git = "https://github.com/dashpay/grovedb", rev = "b5bd7efd65a3cc6bbe22ef9ccc098c4396dcf636", optional = true }
 
 [dev-dependencies]
 tokio = { version = "1.40", features = ["full"] }

packages/rs-dpp/Cargo.toml

@@ -82,7 +82,7 @@ derive_more = { version = "1.0", features = ["from", "deref", "deref_mut"] }
 async-trait = "0.1.77"
 console-subscriber = { version = "0.4", optional = true }
 bls-signatures = { git = "https://github.com/dashpay/bls-signatures", rev = "0842b17583888e8f46c252a4ee84cdfd58e0546f", optional = true }
-grovedb-commitment-tree = { git = "https://github.com/dashpay/grovedb", rev = "d473818154dac668676fcb54678287845032d9a7" }
+grovedb-commitment-tree = { git = "https://github.com/dashpay/grovedb", rev = "b5bd7efd65a3cc6bbe22ef9ccc098c4396dcf636" }
 nonempty = "0.11"
 # Shielded-pool snapshot needs raw RocksDB SstFileWriter + ingest_external_file_cf
 # bindings, and blake3 for the snapshot-file checksum.
@@ -107,7 +107,7 @@ dpp = { path = "../rs-dpp", default-features = false, features = [
 drive = { path = "../rs-drive", features = ["fixtures-and-mocks"] }
 drive-proof-verifier = { path = "../rs-drive-proof-verifier" }
 strategy-tests = { path = "../strategy-tests" }
-grovedb-commitment-tree = { git = "https://github.com/dashpay/grovedb", rev = "d473818154dac668676fcb54678287845032d9a7", features = ["client"] }
+grovedb-commitment-tree = { git = "https://github.com/dashpay/grovedb", rev = "b5bd7efd65a3cc6bbe22ef9ccc098c4396dcf636", features = ["client"] }
 assert_matches = "1.5.0"
 drive-abci = { path = ".", features = ["testing-config", "mocks", "shielded_test_data"] }
 bls-signatures = { git = "https://github.com/dashpay/bls-signatures", rev = "0842b17583888e8f46c252a4ee84cdfd58e0546f" }
@@ -121,8 +121,8 @@ integer-encoding = { version = "4.0.0" }
 
 # For dump_only_default_and_aux_cfs_under_shielded_subtree_prefix — same
 # subtree-prefix algorithm grovedb uses internally.
-grovedb-path = { git = "https://github.com/dashpay/grovedb", rev = "d473818154dac668676fcb54678287845032d9a7" }
-grovedb-storage = { git = "https://github.com/dashpay/grovedb", rev = "d473818154dac668676fcb54678287845032d9a7" }
+grovedb-path = { git = "https://github.com/dashpay/grovedb", rev = "b5bd7efd65a3cc6bbe22ef9ccc098c4396dcf636" }
+grovedb-storage = { git = "https://github.com/dashpay/grovedb", rev = "b5bd7efd65a3cc6bbe22ef9ccc098c4396dcf636" }
 
 [features]
 default = ["bls-signatures"]

packages/rs-drive-abci/Cargo.toml

@@ -644,7 +644,7 @@ mod tests {
 
         assert_eq!(
             processing_result.aggregated_fees().processing_fee,
-            24002492770
+            24002489210
         );
 
         let check_result = platform
@@ -849,7 +849,7 @@ mod tests {
         // We have one invalid paid for state transition
         assert_eq!(processing_result.invalid_paid_count(), 1);
 
-        assert_eq!(processing_result.aggregated_fees().processing_fee, 350220);
+        assert_eq!(processing_result.aggregated_fees().processing_fee, 346660);
 
         let check_result = platform
             .check_tx(
@@ -1159,7 +1159,7 @@ mod tests {
         // Plus we have 24_000_000_000 in base costs
         assert_eq!(
             processing_result.aggregated_fees().processing_fee,
-            24004985540
+            24004978420
         );
 
         let check_result = platform
@@ -1634,7 +1634,7 @@ mod tests {
 
         assert_eq!(
             processing_result.aggregated_fees().processing_fee,
-            24002492770
+            24002489210
         );
 
         platform
@@ -1721,7 +1721,7 @@ mod tests {
 
         assert_eq!(
             update_processing_result.aggregated_fees().processing_fee,
-            27002568170
+            27002504030
         );
 
         let check_result = platform
@@ -2093,7 +2093,7 @@ mod tests {
 
         assert_eq!(
             processing_result.aggregated_fees().processing_fee,
-            24002492770
+            24002489210
         );
 
         platform

packages/rs-drive-abci/src/execution/check_tx/v0/mod.rs

@@ -7769,8 +7769,8 @@ mod tests {
 
             // Assert exact values - 2 inputs should cost more processing than 1 input
             assert_eq!(
-                processing_fee, 593080,
-                "Processing fee changed! Was 593080, now {}",
+                processing_fee, 589280,
+                "Processing fee changed! Was 589280, now {}",
                 processing_fee
             );
             assert_eq!(
@@ -7779,8 +7779,8 @@ mod tests {
                 storage_fee
             );
             assert_eq!(
-                total_fee, 6668080,
-                "Total fee changed! Was 6668080, now {}",
+                total_fee, 6664280,
+                "Total fee changed! Was 6664280, now {}",
                 total_fee
             );
         }
@@ -8239,8 +8239,8 @@ mod tests {
 
             // Assert exact values
             assert_eq!(
-                processing_fee, 3035320,
-                "Processing fee changed! Was 3035320, now {}",
+                processing_fee, 2959680,
+                "Processing fee changed! Was 2959680, now {}",
                 processing_fee
             );
             assert_eq!(
@@ -8249,8 +8249,8 @@ mod tests {
                 storage_fee
             );
             assert_eq!(
-                total_fee, 9110320,
-                "Total fee changed! Was 9110320, now {}",
+                total_fee, 9034680,
+                "Total fee changed! Was 9034680, now {}",
                 total_fee
             );
         }
@@ -8394,8 +8394,8 @@ mod tests {
 
             // Assert exact values for existing address (much cheaper - only updates balance)
             assert_eq!(
-                total_fee_existing, 451180,
-                "Total fee to existing address changed! Was 451180, now {}",
+                total_fee_existing, 447400,
+                "Total fee to existing address changed! Was 447400, now {}",
                 total_fee_existing
             );
         }

packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/address_funds_transfer/tests.rs

@@ -10,7 +10,7 @@ mod deletion_tests {
     async fn test_document_delete_on_document_type_that_is_mutable_and_can_be_deleted() {
         run_document_delete_on_document_type_that_is_mutable_and_can_be_deleted_at_protocol_version(
             PlatformVersion::latest().protocol_version,
-            1699540,
+            1678920,
         )
         .await;
     }
@@ -370,7 +370,7 @@ mod deletion_tests {
     async fn test_document_delete_on_document_type_that_is_not_mutable_and_can_be_deleted() {
         run_document_delete_on_document_type_that_is_not_mutable_and_can_be_deleted_at_protocol_version(
             PlatformVersion::latest().protocol_version,
-            2838880,
+            2778700,
         )
         .await;
     }

packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/tests/document/deletion.rs

@@ -23,7 +23,7 @@ mod dpns_tests {
     async fn test_dpns_contract_references_with_no_contested_unique_index() {
         run_dpns_contract_references_with_no_contested_unique_index_at_protocol_version(
             PlatformVersion::latest().protocol_version,
-            6_014_380,
+            6_010_380,
         )
         .await;
     }

packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/tests/document/dpns.rs

@@ -408,7 +408,7 @@ mod nft_tests {
             PlatformVersion::latest().protocol_version,
             126440160,
             2485600,
-            4126900,
+            4092360,
         )
         .await;
     }
@@ -829,7 +829,7 @@ mod nft_tests {
             141238960,
             2729120,
             2733160,
-            4397020,
+            4357440,
         )
         .await;
     }
@@ -1407,7 +1407,7 @@ mod nft_tests {
             PlatformVersion::latest().protocol_version,
             126440160,
             2485600,
-            4126900,
+            4092360,
         )
         .await;
     }

packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/batch/tests/document/nft.rs

@@ -213,7 +213,7 @@ mod transfer_tests {
     async fn test_document_transfer_on_document_type_that_is_transferable_before_creator_id() {
         run_document_transfer_on_document_type_that_is_transferable_before_creator_id_at_protocol_version(
             PlatformVersion::latest().protocol_version,
-            3403080,
+            3380960,
         )
         .await;
     }
@@ -496,7 +496,7 @@ mod transfer_tests {
     async fn test_document_transfer_on_document_type_that_is_transferable() {
         run_document_transfer_on_document_type_that_is_transferable_at_protocol_version(
             PlatformVersion::latest().protocol_version,
-            3665520,
+            3643400,
         )
         .await;
     }
@@ -779,7 +779,7 @@ mod transfer_tests {
     async fn test_document_transfer_on_document_type_that_is_transferable_contract_v0() {
         run_document_transfer_on_document_type_that_is_transferable_contract_v0_at_protocol_version(
             PlatformVersion::latest().protocol_version,
-            3403080,
+            3380960,
         )
         .await;
     }
@@ -1467,7 +1467,7 @@ mod transfer_tests {
     async fn test_document_delete_after_transfer() {
         run_document_delete_after_transfer_at_protocol_version(
             PlatformVersion::latest().protocol_version,
-            4035120,
+            4004260,
         )
         .await;
     }