Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(dashmate): dashmate helper crashes on enourmously high linux uid #1940

Open
pshenmic opened this issue Jul 10, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@pshenmic
Copy link
Collaborator

pshenmic commented Jul 10, 2024

Issue

Some distributions and VPS hosters may create weird linux users with enourmosly high linux user ID, dashmate should not allow users to run dashmate under users with such ids

Expected Behavior

Dashmate should throw a error when discover an overflow linux uid/gid

Current Behavior

Dashmate helper continuously restarts

Possible Solution

Check LOCAL_UID and LOCAL_GID before starting services in the DockerCompose.js

Steps to Reproduce (for bugs)

nphne-ll7u2s3d@test1:~$ id
uid=866391160(nphne-ll7u2s3d) gid=866391160(nphne-ll7u2s3d) groups=866391160(nphne-ll7u2s3d),44(video),988(docker)
Starting with UID: 866391160, GID: 866391160, USER: dashmate, GROUP: docker
su: unknown user dashmate
Creating user dashmate (866391160)
adduser: number 866391160 is not in 0..256000 range
Group exist: docker 988

@pshenmic pshenmic added the bug Something isn't working label Jul 10, 2024
@pshenmic pshenmic changed the title bug(dashmate): dashmate hlper bug(dashmate): dashmate helper crashes on enourmously high linux uid Jul 10, 2024
@shumkov
Copy link
Member

shumkov commented Sep 23, 2024

@pshenmic What do you think dashmate should do? Do not start services with an error that the user ID is too high and a user needs to create another one with a lower ID? I'm not sure the user can even create a user in such an environment. Do you have access to this VPS?

@shumkov shumkov self-assigned this Sep 23, 2024
@shumkov shumkov moved this to Backlog in Platform team Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants