Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashmate): Add contract and block height data to dashmate status output #540

Open
pshenmic opened this issue Sep 23, 2022 · 8 comments
Assignees
Labels
dashmate Dashmate related enhancement New feature or request

Comments

@pshenmic
Copy link
Collaborator

pshenmic commented Sep 23, 2022

Expected Behavior

Dashmate status command have info about block height data

Current Behavior

It does not show block height data

Possible Solution

Add block height data to the status command. Additionally, the fallback strategy for obtaining best block height should be implemented.
Call to the external blockchain explorer is used in dashmate status for obtaining the correct chain for best block height and its used as truth of source. This call can fail, server may be down, or other reasons, and this leads to the command fail as well. Add fallback to the getchaintips dashcore RPC method and mark the information as the local by coloring it in yellow.

@pshenmic pshenmic added the enhancement New feature or request label Sep 23, 2022
@pshenmic pshenmic self-assigned this Oct 5, 2022
@pshenmic pshenmic added the dashmate Dashmate related label Oct 5, 2022
@pshenmic pshenmic added this to the v0.24.0 milestone Mar 15, 2023
@pshenmic
Copy link
Collaborator Author

pshenmic commented Apr 18, 2023

Remote block height is currently broken in v24, because insight is answering too slow, shall we create another task for fallin back to getchaintips?

@shumkov
Copy link
Member

shumkov commented Apr 19, 2023

Why it works in v0.23 then?

@pshenmic
Copy link
Collaborator Author

pshenmic commented Apr 19, 2023

Why it works in v0.23 then?

In v23 there is no client timeout implemented and it simply waits for the response and it can take ages to receive the answer (that is why status command is slow in v23). If the request dropped by timeout with server, the command will throw an error

@shumkov
Copy link
Member

shumkov commented Apr 19, 2023

I'm not sure getchaintips will help us to indicate that node is not actually syncing. @strophy what do you think?

@strophy
Copy link
Collaborator

strophy commented May 2, 2023

getchaintips will usually show if a particular node has at least heard of nodes with a higher block height, but really we should treat insight (and a fallback) as a reliable external source of block height. We should diagnose why insight is replying slowly instead maybe, there has been an update there in the last few weeks.

@shumkov
Copy link
Member

shumkov commented May 3, 2023

@strophy According to what you saying the fallback will confuse people because you don't know is it a view from outside or just vision of an isolated node.

@strophy
Copy link
Collaborator

strophy commented May 3, 2023

In the event of a chain fork, everyone will be trying to figure out if they are on an isolated network or if the insight/fallback data is incorrect because the remote source ended up on a chain fork. I think the best option here in the status command is to provide multiple clearly labeled block heights to help people diagnose errors quickly, and highlight our height in green if matches insight.

@shumkov
Copy link
Member

shumkov commented May 3, 2023

Sounds good to me!

@shumkov shumkov modified the milestones: v0.24.0, v0.25.0 May 10, 2023
@shumkov shumkov removed this from the v0.25.0 milestone Sep 26, 2024
@shumkov shumkov moved this to Backlog in Platform team Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashmate Dashmate related enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

3 participants