Skip to content

Commit 9bc580d

Browse files
shumkovclaude
andauthored
ci: PR Hygiene is the merge gate; CODEOWNERS carries no rules (#1039)
The PR Hygiene status now passes only when the review policy is satisfied and is pending while anything is still waiting, so it can be required to merge. With it required, GitHub own approval count on this branch goes to zero and the policy is the one thing that decides: an author who owns every area they touched needs the bots, their attestation and a green build; anyone else also needs an owner approval. CODEOWNERS is a file with no rules now, on purpose. A rule there had GitHub request every owner the moment a pull request was opened, before the bots or the author had read it. The file stays, pointing at the policy. dashpay/stale_prs_are_bad#37 landed as 2a9705fbefd4294f490baa36f46f2b880a592502. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 3d24459 commit 9bc580d

2 files changed

Lines changed: 16 additions & 9 deletions

File tree

.github/CODEOWNERS

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
# Generated from dashpay/stale_prs_are_bad policies/rust-dashcore.json; do not edit by hand.
2-
# Owners and reviewers are combined here for native review routing.
3-
* @QuantumExplorer
4-
# Unresolved ownership or reviewer identities; see responsibility documentation.
5-
/dash-spv/ @ZocoLini @xdustinface
6-
# Unresolved ownership or reviewer identities; see responsibility documentation.
7-
/key-wallet/ @QuantumExplorer @ZocoLini @xdustinface
8-
# Unresolved ownership or reviewer identities; see responsibility documentation.
9-
/key-wallet-manager/ @QuantumExplorer @ZocoLini @xdustinface
2+
#
3+
# Review routing for this repository is controlled by PR Hygiene:
4+
# https://github.com/dashpay/stale_prs_are_bad/blob/master/policies/rust-dashcore.json
5+
#
6+
# This file has no rules on purpose. Reviewers are requested by the policy
7+
# once the bots have reported and the author has self-reviewed, not by
8+
# GitHub the moment a pull request is opened.

.github/workflows/pr-review-policy.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@ on:
1111
pull_request_review:
1212
types: [submitted, edited, dismissed]
1313
workflow_dispatch:
14+
inputs:
15+
scope:
16+
description: 'all reconciles every governed pull request now; batch is the sweep'
17+
type: choice
18+
options: [batch, all]
19+
default: batch
1420
schedule:
1521
- cron: '17 * * * *'
1622
# A build turning green raises no event this controller hears. This one
@@ -45,4 +51,6 @@ jobs:
4551
(contains(fromJSON('["coderabbitai", "coderabbitai[bot]"]'), github.event.comment.user.login) &&
4652
(contains(github.event.comment.body, 'final_review_risk_coverage') ||
4753
contains(github.event.comment.body, 'rate limited by coderabbit.ai')))
48-
uses: dashpay/stale_prs_are_bad/.github/workflows/pr-review-reusable.yml@6636e320352dfafaa8187eb73b2d51c9975f2a48
54+
uses: dashpay/stale_prs_are_bad/.github/workflows/pr-review-reusable.yml@2a9705fbefd4294f490baa36f46f2b880a592502
55+
with:
56+
scope: ${{ inputs.scope || 'batch' }}

0 commit comments

Comments
 (0)