TST: update -xfails for complex special cases #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new xfail entries for complex number special cases in test suites, aligned with changes from array-api-tests pull request #409.
Changes:
- Added xfail entries for complex special cases involving functions like
acos,expm1,log1p,sqrt, andtanh - Updated test configuration files for torch, dask, and cupy array implementations
- Documented failures for edge cases with infinity, NaN, and zero values in complex numbers
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| torch-xfails.txt | Added 14 xfail entries for complex special cases including acos, expm1, log1p, sqrt, and tanh functions |
| dask-xfails.txt | Added 9 xfail entries for complex special cases focusing on expm1, sqrt, and tanh functions |
| cupy-xfails.txt | Added 9 xfail entries for complex special cases including acosh, log, log1p, sqrt, and tanh functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ev-br
force-pushed
the
upd_spec_cases_xfails
branch
3 times, most recently
from
a02ae5a to
0e09204
Compare
ev-br
force-pushed
the
upd_spec_cases_xfails
branch
from
0e09204 to
8e98058
Compare
Member
Author
|
All green on CI now. Merging to remove noise from unrelated PRs. Might want to report xfails to numpy/torch at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New xfails for complex special cases, cf data-apis/array-api-tests#409