fix: some issues with artefact size management

Author: albanm

api/src/artefacts/router.ts

@@ -279,6 +279,7 @@ router.post('/:name/versions', async (req, res, next) => {
           category,
           ...(manifest.processingConfigSchema ? { processingConfigSchema: manifest.processingConfigSchema } : {}),
           ...(manifest.applicationConfigSchema ? { applicationConfigSchema: manifest.applicationConfigSchema } : {}),
+          size,
           updatedAt: now,
           dataUpdatedAt: now
         },

api/src/remote-registries/sync.ts

@@ -68,6 +68,7 @@ const syncNpmArtefact = async (ax: AxiosInstance, remoteUrl: string, artefactId:
         ...(remoteArtefact.description ? { description: remoteArtefact.description } : {}),
         ...(remoteArtefact.processingConfigSchema ? { processingConfigSchema: remoteArtefact.processingConfigSchema } : {}),
         ...(remoteArtefact.applicationConfigSchema ? { applicationConfigSchema: remoteArtefact.applicationConfigSchema } : {}),
+        ...(typeof remoteArtefact.size === 'number' ? { size: remoteArtefact.size } : {}),
         origin: remoteUrl,
         updatedAt: now,
         dataUpdatedAt: remoteArtefact.dataUpdatedAt || remoteArtefact.updatedAt

api/src/upgrades/backfill-size.ts

@@ -31,6 +31,21 @@ export const backfillSize = async () => {
         internalError('backfill-size', `artefact ${artefact._id}: ${(err as Error).message || err}`)
       }
     }
+
+    const npmArtefacts = mongo.artefacts.find({ format: 'npm', size: { $exists: false } })
+    for await (const artefact of npmArtefacts) {
+      try {
+        const latest = await mongo.versions.find({ artefactId: artefact._id })
+          .sort({ semverMajor: -1, semverMinor: -1, semverPatch: -1 })
+          .limit(1)
+          .next()
+        if (typeof latest?.size === 'number') {
+          await mongo.artefacts.updateOne({ _id: artefact._id }, { $set: { size: latest.size } })
+        }
+      } catch (err) {
+        internalError('backfill-size', `npm artefact ${artefact._id}: ${(err as Error).message || err}`)
+      }
+    }
   } finally {
     await locks.release('backfill-size')
   }

tests/artefacts.api.spec.ts

@@ -34,6 +34,9 @@ test.describe('Artefacts', () => {
       expect(res.data.artefact.name).toBe('@test/processing-hello')
       expect(res.data.artefact.category).toBe('processing')
       expect(res.data.version.version).toBe('1.0.0')
+      // npm artefact mirrors the latest version's tarball size for prominent display
+      expect(typeof res.data.artefact.size).toBe('number')
+      expect(res.data.artefact.size).toBeGreaterThan(0)
 
       // Audit trail: version detail carries uploadedBy
       const admin = await superAdmin
@@ -43,6 +46,7 @@ test.describe('Artefacts', () => {
       expect(detail.data.uploadedBy.apiKeyName).toBe('test-upload')
       expect(typeof detail.data.size).toBe('number')
       expect(detail.data.size).toBeGreaterThan(0)
+      expect(detail.data.size).toBe(res.data.artefact.size)
     })
 
     test('upload without API key returns 401', async () => {
@@ -697,15 +701,19 @@ test.describe('File artefacts', () => {
 
       // Simulate pre-existing rows: drop size, then run upgrade
       await resetSize()
-      const beforeNpm = await admin.get('/api/v1/artefacts/%40test%2Fsized-pkg%401/versions/1.0.0')
-      expect(beforeNpm.data.size).toBeUndefined()
+      const beforeNpmVer = await admin.get('/api/v1/artefacts/%40test%2Fsized-pkg%401/versions/1.0.0')
+      expect(beforeNpmVer.data.size).toBeUndefined()
+      const beforeNpmArtefact = await admin.get('/api/v1/artefacts/%40test%2Fsized-pkg%401')
+      expect(beforeNpmArtefact.data.size).toBeUndefined()
       const beforeFile = await admin.get('/api/v1/artefacts/sized-file')
       expect(beforeFile.data.size).toBeUndefined()
 
       await runBackfillSize()
 
-      const afterNpm = await admin.get('/api/v1/artefacts/%40test%2Fsized-pkg%401/versions/1.0.0')
-      expect(afterNpm.data.size).toBe(tarballSize)
+      const afterNpmVer = await admin.get('/api/v1/artefacts/%40test%2Fsized-pkg%401/versions/1.0.0')
+      expect(afterNpmVer.data.size).toBe(tarballSize)
+      const afterNpmArtefact = await admin.get('/api/v1/artefacts/%40test%2Fsized-pkg%401')
+      expect(afterNpmArtefact.data.size).toBe(tarballSize)
       const afterFile = await admin.get('/api/v1/artefacts/sized-file')
       expect(afterFile.data.size).toBe(Buffer.byteLength('hello-world-bytes'))
     })

ui/src/pages/admin/artefacts/[id].vue

@@ -78,15 +78,14 @@
             </v-chip>
           </v-col>
           <v-col
-            v-if="artefact.format === 'file'"
             cols="12"
             sm="6"
             md="4"
           >
             <div class="text-medium-emphasis text-body-2">
               {{ t('size') }}
             </div>
-            <div>{{ artefact.size != null ? formatBytes(artefact.size, locale) : '-' }}</div>
+            <div>{{ typeof artefact.size === 'number' ? formatBytes(artefact.size, locale) : '-' }}</div>
           </v-col>
           <v-col
             cols="12"

ui/src/pages/admin/artefacts/index.vue

@@ -65,6 +65,7 @@
             <th>{{ t('name') }}</th>
             <th>{{ t('category') }}</th>
             <th>{{ t('version') }}</th>
+            <th>{{ t('size') }}</th>
             <th>{{ t('visibility') }}</th>
             <th>{{ t('dataUpdatedAt') }}</th>
           </tr>
@@ -98,6 +99,7 @@
               </v-chip>
             </td>
             <td>{{ artefact.version }}</td>
+            <td>{{ typeof artefact.size === 'number' ? formatBytes(artefact.size, locale) : '-' }}</td>
             <td>
               <v-icon
                 :icon="artefact.public ? mdiEye : mdiEyeOff"
@@ -133,6 +135,7 @@ fr:
   recent: Récents
   name: Nom
   version: Version
+  size: Taille
   visibility: Visibilité
   dataUpdatedAt: Données mises à jour
   total: artefact(s)
@@ -145,6 +148,7 @@ en:
   recent: Recent
   name: Name
   version: Version
+  size: Size
   visibility: Visibility
   dataUpdatedAt: Data updated
   total: artefact(s)

ui/src/pages/artefacts/[id].vue

@@ -126,6 +126,26 @@
               {{ categoryLabel(artefact.category, locale) }}
             </v-chip>
           </v-col>
+          <v-col
+            cols="12"
+            sm="6"
+            md="4"
+          >
+            <div class="text-medium-emphasis text-body-2">
+              {{ t('size') }}
+            </div>
+            <div>{{ typeof artefact.size === 'number' ? formatBytes(artefact.size, locale) : '-' }}</div>
+          </v-col>
+          <v-col
+            cols="12"
+            sm="6"
+            md="4"
+          >
+            <div class="text-medium-emphasis text-body-2">
+              {{ t('dataUpdatedAt') }}
+            </div>
+            <div>{{ artefact.dataUpdatedAt ? dayjs(artefact.dataUpdatedAt).format('L LT') : '-' }}</div>
+          </v-col>
           <v-col
             v-if="description"
             cols="12"
@@ -212,6 +232,7 @@ fr:
   version: Version
   architecture: Architecture
   size: Taille
+  dataUpdatedAt: "Donn\xE9es mises \xE0 jour le"
   uploadedAt: "T\xE9l\xE9vers\xE9 le"
   downloadLatest: "T\xE9l\xE9charger la derni\xE8re version"
   download: "T\xE9l\xE9charger"
@@ -229,6 +250,7 @@ en:
   version: Version
   architecture: Architecture
   size: Size
+  dataUpdatedAt: Data updated
   uploadedAt: Uploaded
   downloadLatest: Download Latest
   download: Download

ui/src/pages/artefacts/index.vue

@@ -76,6 +76,7 @@
               <th>{{ t('name') }}</th>
               <th>{{ t('category') }}</th>
               <th>{{ t('version') }}</th>
+              <th>{{ t('size') }}</th>
               <th>{{ t('dataUpdatedAt') }}</th>
             </tr>
           </thead>
@@ -100,6 +101,7 @@
                 </v-chip>
               </td>
               <td>{{ artefact.version || '-' }}</td>
+              <td>{{ typeof artefact.size === 'number' ? formatBytes(artefact.size, locale) : '-' }}</td>
               <td>{{ artefact.dataUpdatedAt ? dayjs(artefact.dataUpdatedAt).format('L LT') : '-' }}</td>
             </tr>
           </tbody>
@@ -243,6 +245,7 @@ fr:
   recent: "R\xE9cents"
   name: Nom
   version: Version
+  size: Taille
   dataUpdatedAt: "Donn\xE9es mises \xE0 jour"
   total: artefact(s)
   createKey: "Cr\xE9er une cl\xE9 de lecture"
@@ -262,6 +265,7 @@ en:
   recent: Recent
   name: Name
   version: Version
+  size: Size
   dataUpdatedAt: Data updated
   total: artefact(s)
   createKey: Create read key