feat: add OIDC_ALLOW_ALL_USERS , allow all users to access, even those not in the allowed groups.
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add scope variable hint.
NeroBlackstone
changed the title
OIDC_ALLOW_ALL_USERS , Allow access to all users, even those not in the allowed groups.
NeroBlackstone
changed the title
OIDC_ALLOW_ALL_USERS , Allow access to all users, even those not in the allowed groups.OIDC_ALLOW_ALL_USERS , allow all users to access, even those not in the allowed groups.
|
If you find it inconvenient to review, I can close this PR and split it into other PRs (I think the code changes will be clearer this way). |
|
dear @NeroBlackstone, regarding the GitLab integration case, could you check if it can be implemented as an independent plugin (similar to how group retrieval works for MS Entra ID)? |
|
Close PR for split it into other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Add OIDC_ALLOW_ALL_USERS to allow all users to access.
Motivation: Assuming there is a self-hosted gitlab in the organization, all users in gitlab should have authorized to access MLFlow. Save the trouble of manually adding them to the group one by one
Added a script to initialize the development environment.(clear authorized user data)
Add
strtoboolfunction, avoiding dependencies on distutilsAvoid warnings:
Usage of '~' in imports is deprecated.Fix bugs: If there is no
groupsfield in theid tokenanduserinfo, HTTP 500 will be caused