Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spade - Bitswap Retrieval Worker #32

Closed
Tracked by #46
jcace opened this issue Sep 12, 2023 · 5 comments · Fixed by data-preservation-programs/SpadeRetrievalBot#1
Closed
Tracked by #46

Spade - Bitswap Retrieval Worker #32

jcace opened this issue Sep 12, 2023 · 5 comments · Fixed by data-preservation-programs/SpadeRetrievalBot#1
Assignees
@jcace

Comments

@jcace
Copy link
Contributor

jcace commented Sep 12, 2023 •
edited
Loading

  • Modify/update the Bitswap retrieval worker to support the new retrieve_type: spade retrievals
  • This is a different type of retrieval from the standard bitswap retrievals, as it requires a 3-layer traversal to be done, starting with the source CID and working down 2 layers of the tree to the leaves (data nodes)
  • This is due to how CIDs for DAGhouse are assembled - see https://github.com/filecoin-project/go-dagaggregator-unixfs#grouping-unixfs-structure
@jcace jcace self-assigned this Sep 12, 2023
@github-project-automation github-project-automation bot moved this to 🍇 Backlog in ActionArena Sep 12, 2023
@jcace jcace moved this from 🍇 Backlog to 👨‍💻 In Progress in ActionArena Sep 12, 2023
@jcace jcace mentioned this issue Oct 24, 2023
Closed
@xmcai2016
Copy link

@jcace to link PR here if you want Stephen to look at it

@jcace jcace mentioned this issue Sep 14, 2023
Closed
@anjor anjor assigned xinaxu and unassigned jcace Sep 14, 2023
@anjor
Copy link
Contributor

anjor commented Sep 14, 2023

@xinaxu @ribasushi need your review + merge on this before closing.

@jcace
Copy link
Contributor Author

jcace commented Sep 15, 2023

WIP at #33

Runs separately as a spike for testing, still needs integration done. More details in the PR.

@xmcai2016 xmcai2016 assigned jcace and stephen-pl and unassigned jcace and xinaxu Sep 18, 2023
@xmcai2016
Copy link

@stephen-pl to pick up after ooo. transitioning doc: https://www.notion.so/ecosystem-wg/Jason-OOO-Handoff-3082d25caace46abb5e4f7efff242786?pvs=4

@stephen-pl stephen-pl assigned jcace and unassigned stephen-pl Oct 12, 2023
@jcace
Copy link
Contributor Author

jcace commented Oct 12, 2023

Still WIP, solving a bug with the Bitswap libp2p code

@jcace jcace mentioned this issue Oct 17, 2023
Merged
@github-project-automation github-project-automation bot moved this from 👨‍💻 In Progress to 🚢 Done in ActionArena Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcace jcace

Labels
None yet
Projects
ActionArena
Status: 🚢 Done
Milestone
No milestone
5 participants
@anjor @jcace @xmcai2016 @xinaxu @stephen-pl