-
Notifications
You must be signed in to change notification settings - Fork 49
conflict of name 'name' #91
Comments
As I recall, this is not the only way in which dat.guiVR alters the properties of three objects, which could in general lead to issues like this emerging at unexpected times. I somewhat considered refactoring so that the THREE objects would be members of the dat.guiVR objects, rather than changing them directly. I might still consider this, but I'm not sure how the original authors feel about it. |
I would suggest using |
The library also redefines |
I stumbled over both naming-conflicts while working with dat.guiVR, causing me some headache. |
I agree threejs compliance might be more important than similarity to the other API, especially given they're unlikely to remain completely equivalent. |
dat.guiVR uses a function name() to set the label.
This conflicts with the pre-existing 'name' field in THREE objects.
This causes some issues, including breaking threejs inspector when inspecting dat.guiVR objects.
I suggest it be replaced by a get/set property 'label'; or (smaller change) renamed to 'label' or 'setName'.
I can't see an easy way to do this without breaking upward compatibility.
The text was updated successfully, but these errors were encountered: