Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bed_format options #100

Open
donaldcampbelljr opened this issue Feb 12, 2025 · 3 comments
Open

Rename bed_format options #100

donaldcampbelljr opened this issue Feb 12, 2025 · 3 comments

Comments

@donaldcampbelljr
Copy link
Member

donaldcampbelljr commented Feb 12, 2025

In an effort to be more specific, we shall rename:

bed -> ucsc_bed

broadPeak -> encode_broadpeak
gappedPeak -> encode_gappedpeak
narrowPeak -> encode_narrowPeak

Additions:

  • encode_rna_elements (already added)

- narrowPeak with column 5 with values greater than 1000 -> ns_narrowpeak ( which stands for non-strict narrowPeak)

@donaldcampbelljr
Copy link
Member Author

Removed ns_narrowpeak as I realized that we would need a special format for all the other bed_formats as well (because they also have a score column with constraints of 0-1000) and that did not feel like the correct approach.

@donaldcampbelljr
Copy link
Member Author

After today's discussion:

rename bed_format to data_format

data_format names will include:

strict (for the strictest compliance):
ucsc_bed (bed#+0)
bed_like (bed#+#>0, and NOT subject to the relaxed score below)
encode_narrowpeak
encode_broadpeak
encode_gappedpeak
encode_rna_elements

relaxed score (in the cases where column 5 is not between 0 and 1000):
bed_rs
encode_narrowpeak_rs
encode_broadpeak_rs
encode_gappedpeak_rs
encode_rna_elements_rs

donaldcampbelljr added a commit that referenced this issue Feb 25, 2025
@donaldcampbelljr
Copy link
Member Author

This is now done via the above refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant