Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clip bam to bed output values using input values from chrom.size file #88

Open
donaldcampbelljr opened this issue Feb 14, 2025 · 1 comment
Labels

Comments

@donaldcampbelljr
Copy link
Member

I have this file UMGC-Mod-084-1s-MN24-d1-D_S44_sort_dedup.bam which does not produce the issue. It appears that the failing file is UMGC-Mod-084-1s-MN09-d1-A_S1_sort_dedup.bam.

Regarding the bed file's last row extending beyond the chrom size, I think that is unrelated to this issue, but we should clip it in the bam_to_bed_no_counts based on input chrom.sizes like we do in the other counting functions.

@nleroy917 Good idea. By the time the program gets this far, it has checked that the chromosomes exist in the bam file. However, it could raise an error during writing to the bed file line by line, but we should see this error in the terminal (which I don't in this case). We could skip that file. As long as the program communicates that it was expecting a chromosome file but didn't find one that would be fine. Currently, the messaging is inadequate either way as I'm not sure which chrom failed from the backtrace. :) Also, I would think the consumer handle would produce an empty file either way by this point.

Originally posted by @donaldcampbelljr in #74

@donaldcampbelljr donaldcampbelljr changed the title Clip bam to bed output values to chrom.size file Clip bam to bed output values using input values from chrom.size file Feb 14, 2025
@donaldcampbelljr
Copy link
Member Author

The original bamsitestowig did not clip this output and would happily create a bed output that extends beyond the chromosome size. Should we actually implement this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant