Skip to content

Add support for Stored Procedures in JDBC driver (Phase 1) #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for Stored Procedures in JDBC driver (Phase 1) #1051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d55d60
Add stored proc support
gopalldb Oct 28, 2025
ceb436a
Fix test
gopalldb Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/databricks/jdbc/api/impl/DatabricksStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,8 @@ static boolean shouldReturnResultSet(String query) {
|| GET_PATTERN.matcher(trimmedQuery).find()
|| REMOVE_PATTERN.matcher(trimmedQuery).find()
|| LIST_PATTERN.matcher(trimmedQuery).find()
|| BEGIN_PATTERN_FOR_SQL_SCRIPT.matcher(trimmedQuery).find();
|| BEGIN_PATTERN_FOR_SQL_SCRIPT.matcher(trimmedQuery).find()
|| CALL_PATTERN.matcher(trimmedQuery).find();

// Otherwise, it should not return a ResultSet
}
Expand Down
6 changes: 4 additions & 2 deletions src/main/java/com/databricks/jdbc/common/DatabricksJdbcConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,15 +159,17 @@ public enum FakeServiceType {
public static final Pattern DECLARE_PATTERN =
Pattern.compile("^(\\s*\\()*\\s*DECLARE", Pattern.CASE_INSENSITIVE);
public static final Pattern PUT_PATTERN =
Pattern.compile("^(\\s*\\()*\\s*GET", Pattern.CASE_INSENSITIVE);
public static final Pattern GET_PATTERN =
Pattern.compile("^(\\s*\\()*\\s*PUT", Pattern.CASE_INSENSITIVE);
public static final Pattern GET_PATTERN =
Pattern.compile("^(\\s*\\()*\\s*GET", Pattern.CASE_INSENSITIVE);
public static final Pattern REMOVE_PATTERN =
Pattern.compile("^(\\s*\\()*\\s*REMOVE", Pattern.CASE_INSENSITIVE);
public static final Pattern LIST_PATTERN =
Pattern.compile("^(\\s*\\()*\\s*LIST", Pattern.CASE_INSENSITIVE);
public static final Pattern INSERT_PATTERN =
Pattern.compile("^(\\s*\\()*\\s*INSERT\\s+INTO", Pattern.CASE_INSENSITIVE);
public static final Pattern CALL_PATTERN =
Pattern.compile("^(\\s*\\()*\\s*CALL", Pattern.CASE_INSENSITIVE);

/** Maximum number of parameters allowed in a single Databricks query */
public static final int MAX_QUERY_PARAMETERS = 256;
Expand Down
8 changes: 8 additions & 0 deletions src/test/java/com/databricks/jdbc/api/impl/DatabricksStatementTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,14 @@ public void testShouldReturnResultSet_CommentSurroundingQuery() {
assertTrue(DatabricksStatement.shouldReturnResultSet(query));
}

@Test
public void testShouldReturnResultSet_CallStatement() {
String query =
"-- Single-line comment\n/* Multi-line comment */ CALL send_notifications(12); /* Another comment */ -- End comment";
assertTrue(DatabricksStatement.shouldReturnResultSet(query));
assertTrue(DatabricksStatement.shouldReturnResultSet("CALL send_notifications(12);"));
}

@Test
public void testShouldReturnResultSet_StartWithBegin() {
assertTrue(DatabricksStatement.shouldReturnResultSet("BEGIN"));
Expand Down
Loading