Commit e727547
authored
## Changes
This PR introduces a workaround for a `DATABRICKS_HOST` normalisation
issue in the underlying Python SDK (databricks/databricks-sdk-py#996).
We fixed this for the CLI entry points in #1706 but missed the `install`
and `uninstall` hooks, which this PR addresses.
### Relevant implementation details
The actual workaround is implemented in Blueprint, but a bit hard to get
to… the easiest way to get to it without modifying Blueprint is to
introduce the `App` subclass.
### Linked issues
Resolves #2037
### Functionality
- modified existing commands:
- `databricks labs install lakebridge`
- `databricks labs uninstall lakebridge`
### Tests
Manually tested, see logs below:
- Normal situation, with `host=` set to just a host:
- [`databricks labs install lakebridge
--debug`](https://github.com/user-attachments/files/22517659/install-normal.log)
- [`databricks labs uninstall lakebridge
--debug`](https://github.com/user-attachments/files/22517616/uninstall-normal.log)
- Situation with `host=` set to a login URL:
- [`databricks labs install lakebridge
--debug`](https://github.com/user-attachments/files/22517675/install-with-workaround.log)
- [`databricks labs uninstall lakebridge
--debug`](https://github.com/user-attachments/files/22517697/uninstall-with-workaround.log)
1 parent 8ae887a commit e727547
File tree
3 files changed
+17
-14
lines changed- src/databricks/labs/lakebridge
3 files changed
+17
-14
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | | - | |
| 7 | + | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
| |||
18 | 17 | | |
19 | 18 | | |
20 | 19 | | |
21 | | - | |
| 20 | + | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
46 | 58 | | |
47 | 59 | | |
48 | 60 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | | - | |
| 5 | + | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
18 | 17 | | |
19 | 18 | | |
20 | 19 | | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
| 20 | + | |
0 commit comments