From e6d1d017a4b5ac8e2dfce8e76effe5f0790fffb9 Mon Sep 17 00:00:00 2001 From: M Abulazm Date: Tue, 23 Sep 2025 14:39:56 +0200 Subject: [PATCH] change log message on successful recon aggregate runs --- .../labs/lakebridge/reconcile/recon_capture.py | 8 +++++++- .../labs/lakebridge/reconcile/reconciliation.py | 14 +++++--------- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/databricks/labs/lakebridge/reconcile/recon_capture.py b/src/databricks/labs/lakebridge/reconcile/recon_capture.py index c25c6af573..c2073d2a61 100644 --- a/src/databricks/labs/lakebridge/reconcile/recon_capture.py +++ b/src/databricks/labs/lakebridge/reconcile/recon_capture.py @@ -579,7 +579,13 @@ def _insert_aggregates_into_details_table( ) agg_details_df_list.append(agg_details_rule_df) else: - logger.warning("Aggregate Details Rules are empty") + logger.info( + f"Aggregate rule reconciliation is successful." + f" No details to store." + f" Rule: {agg_output.rule.column_from_rule}" + if agg_output.rule + else "" + ) if agg_details_df_list: agg_details_table_df = self._union_dataframes(agg_details_df_list) diff --git a/src/databricks/labs/lakebridge/reconcile/reconciliation.py b/src/databricks/labs/lakebridge/reconcile/reconciliation.py index f8240f75db..4b9fa8b23c 100644 --- a/src/databricks/labs/lakebridge/reconcile/reconciliation.py +++ b/src/databricks/labs/lakebridge/reconcile/reconciliation.py @@ -31,7 +31,6 @@ from databricks.labs.lakebridge.reconcile.recon_config import ( Schema, Table, - AggregateQueryRules, SamplingOptions, ) from databricks.labs.lakebridge.reconcile.recon_output_config import ( @@ -212,21 +211,18 @@ def _get_reconcile_aggregate_output( #3, MAX, COL3, """ - src_query_builder = AggregateQueryBuilder( + # build Aggregate queries for source, There could be one + # or more queries per table based on the group by columns + src_agg_queries = AggregateQueryBuilder( table_conf, src_schema, "source", self._source_engine, self._source, - ) - - # build Aggregate queries for source, - src_agg_queries: list[AggregateQueryRules] = src_query_builder.build_queries() - - # There could be one or more queries per table based on the group by columns + ).build_queries() # build Aggregate queries for target(Databricks), - tgt_agg_queries: list[AggregateQueryRules] = AggregateQueryBuilder( + tgt_agg_queries = AggregateQueryBuilder( table_conf, tgt_schema, "target",