Fixes Issue#30 "--rpl-user and --db-user should not allow root"

Author: datacharmer

Changelog

@@ -1,3 +1,5 @@
+1.8.4	11-Aug-2018
+	- Fixed Issue #30 "--rpl-user and --db-user should not allow root"
 1.8.3	05-Aug-2018
 	- Fixed Issue #26 "Port management glitch"
 1.8.2	05-Aug-2018

cmd/single.go

@@ -96,6 +96,15 @@ func check_if_abridged_version(version, basedir string) string {
 	return version
 }
 
+func check_for_root_value(value, label, default_val string) {
+	if value == "root" {
+		common.Exit(1, fmt.Sprintf("option --%s cannot be 'root'", label),
+			"The 'root' user will be initialized regardless,",
+			"using the same password defined for the default db-user.",
+			fmt.Sprintf("The default user for this option is '%s'.", default_val))
+	}
+}
+
 func FillSdef(cmd *cobra.Command, args []string) sandbox.SandboxDef {
 	var sd sandbox.SandboxDef
 
@@ -190,6 +199,9 @@ func FillSdef(cmd *cobra.Command, args []string) sandbox.SandboxDef {
 	sd.DbPassword, _ = flags.GetString(defaults.DbPasswordLabel)
 	sd.RplUser, _ = flags.GetString(defaults.RplUserLabel)
 
+	check_for_root_value(sd.DbUser, defaults.DbUserLabel, defaults.DbUserValue)
+	check_for_root_value(sd.RplUser, defaults.RplUserLabel, defaults.RplUserValue)
+
 	sd.RplPassword, _ = flags.GetString(defaults.RplPasswordLabel)
 	sd.RemoteAccess, _ = flags.GetString(defaults.RemoteAccessLabel)
 	sd.BindAddress, _ = flags.GetString(defaults.BindAddressLabel)

common/version.go

@@ -15,7 +15,7 @@
 
 package common
 
-var VersionDef string = "1.8.3" // 2018-08-05
+var VersionDef string = "1.8.4" // 2018-08-11
 
 // Compatible version is the version used to mark compatible archives (templates, configuration).
 // It is usually major.minor.0, except when we are at version 0.x, when

test/go-unit-tests.sh

@@ -3,7 +3,6 @@ testdir=$(dirname $0)
 cd $testdir
 cd ..
 maindir=$PWD
-ls
 
 function check_exit_code {
     exit_code=$?