Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinMerge 2011.211.110 broke filter functionality #14

Open
engelhro opened this issue Mar 2, 2021 · 3 comments
Open

WinMerge 2011.211.110 broke filter functionality #14

engelhro opened this issue Mar 2, 2021 · 3 comments

Comments

@engelhro
Copy link

engelhro commented Mar 2, 2021

With the new version released some days ago, the file filter functionality during comparison of folders is broken (I use the portable installation):

  • Custom filters are not recognized anymore. The ones I had defined are not found/listed anymore (see also the changed path remark at the end).
  • I even cannot add new ones via button New… (just tested private filters, not shared ones). I can still add one, the file with the filter definition gets created successfully, but after saving it's not listed in the UI and cannot be selected.
  • I cannot add existing ones via button Install…. After providing the path to an existing filter definition, I just receive an error message ("Installing filter file failed. Could not copy new filter file to filter folder.").

And finally the default path has changed? I previously stored my definitions in C:\Users\‹Username›\Documents\WinMerge\Filters, but now WinMerge stores the filters apparently in the ProgramData\WinMerge\Filters sub directory of its (portable) installation path? Copying an existing filter definition to this path also doesn't help.

Can anyone confirm my findings? In case this is really a nasty bug, can it please be fixed? Thanks!

datadiode added a commit that referenced this issue Mar 8, 2021
@datadiode
Copy link
Owner

Thanks for your bug report.

You may want to try the CI build at https://ci.appveyor.com/project/datadiode/winmerge2011/builds/38108231/artifacts.

@engelhro
Copy link
Author

engelhro commented Apr 2, 2021

I've looked at at version 0.2011.211.119, and the problem seems to be fixed only partially…

A filter existing in the defined folder is not recognized automatically. I have to choose the Install… button, select the file with the filter definition, click on Open and then abort with No when asked whether I want to overwrite the existing file (which of I don't want, it already exists with the very same content). But afterwards, the filter definition is finally known to Winmerge2011 int the main comparison dialog and can be selected for folder comparison.

I'm not sure why the behavior of the filter menu had to be changed at all? It was working in previous versions, was there any reason to touch this part of the application?

Thanks for restoring the original functionality! ☺

@datadiode
Copy link
Owner

WinMergeRoot-vs-WinMergeDrive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants