Merge pull request #39 from datafold/gerard-eng-2673-reduce-clickhouse-backup-retention-to-7-days

fix: Update clickhouse backup retention

Author: gtoonstra

README.md

@@ -195,6 +195,7 @@ Now all containers should be up and running.
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
 | <a name="input_add_onprem_support_group"></a> [add\_onprem\_support\_group](#input\_add\_onprem\_support\_group) | Flag to add onprem support group for [email protected] | `bool` | `true` | no |
+| <a name="input_backup_lifecycle_expiration_days"></a> [backup\_lifecycle\_expiration\_days](#input\_backup\_lifecycle\_expiration\_days) | Number of days after which clickhouse backup objects will expire and be deleted. | `number` | `6` | no |
 | <a name="input_ch_machine_type"></a> [ch\_machine\_type](#input\_ch\_machine\_type) | The machine type for the ch GKE cluster nodes | `string` | `"n2-standard-8"` | no |
 | <a name="input_clickhouse_backup_sa_key"></a> [clickhouse\_backup\_sa\_key](#input\_clickhouse\_backup\_sa\_key) | SA key from secrets | `string` | `""` | no |
 | <a name="input_clickhouse_data_disk_size"></a> [clickhouse\_data\_disk\_size](#input\_clickhouse\_data\_disk\_size) | Data volume size clickhouse | `number` | `40` | no |

main.tf

@@ -27,6 +27,7 @@ module "clickhouse_backup" {
   project_id                                 = var.project_id
   clickhouse_get_backup_sa_from_secrets_yaml = var.clickhouse_get_backup_sa_from_secrets_yaml
   legacy_naming                              = var.legacy_naming
+  backup_lifecycle_expiration_days           = var.backup_lifecycle_expiration_days
 }
 
 module "networking" {

modules/clickhouse_backup/main.tf

@@ -15,7 +15,7 @@ resource "google_storage_bucket" "clickhouse_backup" {
 
   lifecycle_rule {
     condition {
-      age = 14
+      age = var.backup_lifecycle_expiration_days
     }
     action {
       type = "Delete"

modules/clickhouse_backup/variables.tf

@@ -40,3 +40,9 @@ variable "legacy_naming" {
   default     = true
   description = "Flag to toggle legacy behavior - like naming of resources"
 }
+
+variable "backup_lifecycle_expiration_days" {
+  type        = number
+  default     = 6
+  description = "Number of days after which clickhouse backup objects will expire and be deleted."
+}

variables.tf

@@ -418,6 +418,12 @@ variable "clickhouse_backup_sa_key" {
   default     = ""
 }
 
+variable "backup_lifecycle_expiration_days" {
+  type        = number
+  default     = 6
+  description = "Number of days after which clickhouse backup objects will expire and be deleted."
+}
+
 # ┏━╸╻╺┳╸╻ ╻╻ ╻┏┓
 # ┃╺┓┃ ┃ ┣━┫┃ ┃┣┻┓
 # ┗━┛╹ ╹ ╹ ╹┗━┛┗━┛